Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2614823003: [Devtools] Network group experiment is now grouped by connectionId (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index beb60625a5d81e83ed75ed71e3bcd4fd35c04e36..f39af33d47771b925fc78ca70b814cd286d6b8bf 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -843,11 +843,14 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
Network.NetworkGroupNode = class extends Network.NetworkNode {
/**
* @param {!Network.NetworkLogView} parentView
- * @param {string} name
+ * @param {string} displayName
+ * @param {string=} sortKey
*/
- constructor(parentView, name) {
+ constructor(parentView, displayName, sortKey) {
super(parentView);
- this._name = name;
+ this._displayName = displayName;
+ // TODO(allada) This is here because you can always sort by _name. This class deserves it's own sorting functions.
+ this._name = sortKey;
}
/**
@@ -868,7 +871,7 @@ Network.NetworkGroupNode = class extends Network.NetworkNode {
var cell = this.createTD(columnIdentifier);
if (columnIdentifier === 'name') {
cell.classList.add('disclosure');
- this._setTextAndTitle(cell, this._name);
+ this._setTextAndTitle(cell, this._displayName);
}
return cell;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698