components/safe_browsing_db/v4_store.h - Issue 2614763002: DCHECK that full hash must be 21 bytes or 32 bytes long.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_store.h

Issue 2614763002: DCHECK that full hash must be 21 bytes or 32 bytes long. (Closed)

Patch Set: Change DCHECK to accept 32 or 21 size. Add unit test. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/v4_store.h

diff --git a/components/safe_browsing_db/v4_store.h b/components/safe_browsing_db/v4_store.h

index ac990b3ddcab44b4dc8753a6babb3a2c984085f7..0deb76a268ca33f066ac95c3655579db7d7c3313 100644

--- a/components/safe_browsing_db/v4_store.h

+++ b/components/safe_browsing_db/v4_store.h

@@ -267,6 +267,7 @@ class V4Store {

TestHashPrefixExistsInMapWithDifferentSizes);

FRIEND_TEST_ALL_PREFIXES(V4StoreTest,

TestHashPrefixDoesNotExistInMapWithDifferentSizes);

+ FRIEND_TEST_ALL_PREFIXES(V4StoreTest, GetMatchingHashPrefixSize32Or21);

FRIEND_TEST_ALL_PREFIXES(V4StoreTest,

TestAdditionsWithRiceEncodingFailsWithInvalidInput);

FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestAdditionsWithRiceEncodingSucceeds);

« no previous file with comments | « no previous file | components/safe_browsing_db/v4_store.cc » ('j') | no next file with comments »