components/safe_browsing_db/v4_store.cc - Issue 2614763002: DCHECK that full hash must be 21 bytes or 32 bytes long.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_store.cc

Issue 2614763002: DCHECK that full hash must be 21 bytes or 32 bytes long. (Closed)

Patch Set: Change DCHECK to accept 32 or 21 size. Add unit test. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/v4_store.cc

diff --git a/components/safe_browsing_db/v4_store.cc b/components/safe_browsing_db/v4_store.cc

index 34eaa27e516cb02164f8ccbb5876b64dbad17108..c46dc584097080a176d7a38d09c6595985f629ba 100644

--- a/components/safe_browsing_db/v4_store.cc

+++ b/components/safe_browsing_db/v4_store.cc

@@ -764,7 +764,7 @@ HashPrefix V4Store::GetMatchingHashPrefix(const FullHash& full_hash) {

// It should never be the case that more than one hash prefixes match a given

// full hash. However, if that happens, this method returns any one of them.

// It does not guarantee which one of those will be returned.

- DCHECK_EQ(32u, full_hash.size());

+ DCHECK(full_hash.size() == 32u || full_hash.size() == 21u);

for (const auto& pair : hash_prefix_map_) {

const PrefixSize& prefix_size = pair.first;

const HashPrefixes& hash_prefixes = pair.second;