Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: components/safe_browsing_db/v4_store.h

Issue 2614763002: DCHECK that full hash must be 21 bytes or 32 bytes long. (Closed)
Patch Set: Change DCHECK to accept 32 or 21 size. Add unit test. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_store.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_STORE_H_ 5 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_STORE_H_
6 #define COMPONENTS_SAFE_BROWSING_DB_V4_STORE_H_ 6 #define COMPONENTS_SAFE_BROWSING_DB_V4_STORE_H_
7 7
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 TestHashPrefixDoesNotExistInConcatenatedList); 260 TestHashPrefixDoesNotExistInConcatenatedList);
261 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestFullHashExistsInMapWithSingleSize); 261 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestFullHashExistsInMapWithSingleSize);
262 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, 262 FRIEND_TEST_ALL_PREFIXES(V4StoreTest,
263 TestFullHashExistsInMapWithDifferentSizes); 263 TestFullHashExistsInMapWithDifferentSizes);
264 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, 264 FRIEND_TEST_ALL_PREFIXES(V4StoreTest,
265 TestHashPrefixExistsInMapWithSingleSize); 265 TestHashPrefixExistsInMapWithSingleSize);
266 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, 266 FRIEND_TEST_ALL_PREFIXES(V4StoreTest,
267 TestHashPrefixExistsInMapWithDifferentSizes); 267 TestHashPrefixExistsInMapWithDifferentSizes);
268 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, 268 FRIEND_TEST_ALL_PREFIXES(V4StoreTest,
269 TestHashPrefixDoesNotExistInMapWithDifferentSizes); 269 TestHashPrefixDoesNotExistInMapWithDifferentSizes);
270 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, GetMatchingHashPrefixSize32Or21);
270 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, 271 FRIEND_TEST_ALL_PREFIXES(V4StoreTest,
271 TestAdditionsWithRiceEncodingFailsWithInvalidInput); 272 TestAdditionsWithRiceEncodingFailsWithInvalidInput);
272 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestAdditionsWithRiceEncodingSucceeds); 273 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestAdditionsWithRiceEncodingSucceeds);
273 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestRemovalsWithRiceEncodingSucceeds); 274 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestRemovalsWithRiceEncodingSucceeds);
274 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestMergeUpdatesFailsChecksum); 275 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestMergeUpdatesFailsChecksum);
275 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestChecksumErrorOnStartup); 276 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, TestChecksumErrorOnStartup);
276 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, WriteToDiskFails); 277 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, WriteToDiskFails);
277 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, FullUpdateFailsChecksumSynchronously); 278 FRIEND_TEST_ALL_PREFIXES(V4StoreTest, FullUpdateFailsChecksumSynchronously);
278 friend class V4StoreTest; 279 friend class V4StoreTest;
279 280
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 const base::FilePath store_path_; 408 const base::FilePath store_path_;
408 HashPrefixMap hash_prefix_map_; 409 HashPrefixMap hash_prefix_map_;
409 const scoped_refptr<base::SequencedTaskRunner> task_runner_; 410 const scoped_refptr<base::SequencedTaskRunner> task_runner_;
410 }; 411 };
411 412
412 std::ostream& operator<<(std::ostream& os, const V4Store& store); 413 std::ostream& operator<<(std::ostream& os, const V4Store& store);
413 414
414 } // namespace safe_browsing 415 } // namespace safe_browsing
415 416
416 #endif // COMPONENTS_SAFE_BROWSING_DB_V4_STORE_H_ 417 #endif // COMPONENTS_SAFE_BROWSING_DB_V4_STORE_H_
OLDNEW
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698