📰 Check we are on the NTP after dismissal animation.

[NTP Client] Check we are on the NTP after dismissal animation.

When dismissing a suggestion through the context menu, it is possible
that by the time the animation ends, we navigated away from the NTP
and it got destroyed, resulting in an NPE. We now exit early when
that is the case.

This CL also reverts the ineffective tentative fix from
https://codereview.chromium.org/2553163002

BUG=668945
Review-Url: https://codereview.chromium.org/2614753002
Cr-Commit-Position: refs/heads/master@{#441917}
Committed: https://chromium.googlesource.com/chromium/src/+/dabb937bae8550231a7ef80705b3f09c4a782aef

[dgn, 2017-01-04 18:11:30]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 18:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2017-01-04 18:11:49]

Description was changed from

==========
[NTP Client] Check we are on the NTP after dismissal animation.

When dismissing a suggestion through the context menu, it is possible
that by the time the animation ends, we navigated away from the NTP
and it got destroyed, resulting in an NPE. We now exit early when
that is the case.

This CL also reverts the ineffective tentative fix from
https://codereview.chromium.org/2553163002

BUG=668945
==========

to

==========
[NTP Client] Check we are on the NTP after dismissal animation.

When dismissing a suggestion through the context menu, it is possible
that by the time the animation ends, we navigated away from the NTP
and it got destroyed, resulting in an NPE. We now exit early when
that is the case.

This CL also reverts the ineffective tentative fix from
https://codereview.chromium.org/2553163002

BUG=668945
==========

[dgn, 2017-01-04 18:11:50]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org

[dgn, 2017-01-04 18:13:06]

PTAL. I don't think merging to 56 is necessary, the repro is quite hard on this
one.

[commit-bot: I haz the power, 2017-01-04 18:49:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 18:49:37]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-01-05 17:36:42]

lgtm

[dgn, 2017-01-06 10:34:17]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2017-01-06 10:34:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 11:07:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483698857506340, "parent_rev":
"84173016b401f5071da19a1d5a591bebc35cbd45", "commit_rev":
"dabb937bae8550231a7ef80705b3f09c4a782aef"}

[commit-bot: I haz the power, 2017-01-06 11:08:21]

Description was changed from

==========
[NTP Client] Check we are on the NTP after dismissal animation.

When dismissing a suggestion through the context menu, it is possible
that by the time the animation ends, we navigated away from the NTP
and it got destroyed, resulting in an NPE. We now exit early when
that is the case.

This CL also reverts the ineffective tentative fix from
https://codereview.chromium.org/2553163002

BUG=668945
==========

to

==========
[NTP Client] Check we are on the NTP after dismissal animation.

When dismissing a suggestion through the context menu, it is possible
that by the time the animation ends, we navigated away from the NTP
and it got destroyed, resulting in an NPE. We now exit early when
that is the case.

This CL also reverts the ineffective tentative fix from
https://codereview.chromium.org/2553163002

BUG=668945

Review-Url: https://codereview.chromium.org/2614753002
Cr-Commit-Position: refs/heads/master@{#441917}
Committed:
https://chromium.googlesource.com/chromium/src/+/dabb937bae8550231a7ef80705b3...
==========

[commit-bot: I haz the power, 2017-01-06 11:08:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dabb937bae8550231a7ef80705b3...