Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2553163002: 📰 Fix crash when tapping the menu on closed NTP (Closed)

Created:
4 years ago by dgn
Modified:
4 years ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Fix crash when tapping the menu on closed NTP Although the menu is supposed to be closed when we navigate away from the NTP, we can crash because of race conditions. This CL adds back checking that the view is attached. BUG=668945 Committed: https://crrev.com/4daca6414728afe3edb8765634effaf113119004 Cr-Commit-Position: refs/heads/master@{#436626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java View 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dgn
PTAL
4 years ago (2016-12-06 16:34:20 UTC) #6
Bernhard Bauer
lgtm
4 years ago (2016-12-06 17:18:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553163002/1
4 years ago (2016-12-06 17:23:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 17:29:36 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 17:32:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4daca6414728afe3edb8765634effaf113119004
Cr-Commit-Position: refs/heads/master@{#436626}

Powered by Google App Engine
This is Rietveld 408576698