Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2614703002: Remove the temporary flag to disable the sync confirmation page on linux an windows. (Closed)

Created:
3 years, 11 months ago by msarda
Modified:
3 years, 11 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the temporary flag to disable the sync confirmation page on linux an windows. This CL removes the temporary hack to disable the sync confirmaton page on linux and windows as the sync confirmation dialog is browser modal on these platforms and thus the dialog is no longer dismissed on page navigation. BUG=657924 Committed: https://crrev.com/0b0b03585ea8daaec2e9aef827a8e44e4dfdbb27 Cr-Commit-Position: refs/heads/master@{#441380}

Patch Set 1 #

Patch Set 2 : Remove the temporary flag to disable the sync confirmation page on linux an windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M chrome/browser/ui/sync/one_click_signin_sync_starter.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
msarda
Please take a look.
3 years, 11 months ago (2017-01-04 14:27:25 UTC) #3
anthonyvd
lgtm
3 years, 11 months ago (2017-01-04 15:00:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614703002/20001
3 years, 11 months ago (2017-01-04 15:02:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 15:48:58 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 15:51:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b0b03585ea8daaec2e9aef827a8e44e4dfdbb27
Cr-Commit-Position: refs/heads/master@{#441380}

Powered by Google App Engine
This is Rietveld 408576698