Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Side by Side Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.h

Issue 2614703002: Remove the temporary flag to disable the sync confirmation page on linux an windows. (Closed)
Patch Set: Remove the temporary flag to disable the sync confirmation page on linux an windows. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_ 5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_
6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_ 6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 std::string client_id_; 253 std::string client_id_;
254 254
255 // This only cares about the first AccountAddedToCookie event. Since 255 // This only cares about the first AccountAddedToCookie event. Since
256 // SigninTracker always expects an observer, this object will just disregard 256 // SigninTracker always expects an observer, this object will just disregard
257 // following AccountAddedToCookie calls triggered by account reconciliation. 257 // following AccountAddedToCookie calls triggered by account reconciliation.
258 bool first_account_added_to_cookie_; 258 bool first_account_added_to_cookie_;
259 259
260 // Prevents Sync from running until configuration is complete. 260 // Prevents Sync from running until configuration is complete.
261 std::unique_ptr<syncer::SyncSetupInProgressHandle> sync_blocker_; 261 std::unique_ptr<syncer::SyncSetupInProgressHandle> sync_blocker_;
262 262
263 // Temporary flag to disable new sync confirm page if user choose to create a 263 // Temporary flag used only on macOS to disable new sync confirm page if user
264 // new profile after the corp account signin. 264 // choose to create a new profile.
265 //
266 // TODO(msarda): Remove this flag once the https://crbug.com/677012 fixed.
265 bool skip_sync_confirm_; 267 bool skip_sync_confirm_;
266 268
267 base::WeakPtrFactory<OneClickSigninSyncStarter> weak_pointer_factory_; 269 base::WeakPtrFactory<OneClickSigninSyncStarter> weak_pointer_factory_;
268 270
269 DISALLOW_COPY_AND_ASSIGN(OneClickSigninSyncStarter); 271 DISALLOW_COPY_AND_ASSIGN(OneClickSigninSyncStarter);
270 }; 272 };
271 273
272 274
273 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_ 275 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_STARTER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698