Don't update TabSpecificContentSettings on same-page navigation

Don't update TabSpecificContentSettings on same-page navigation

This CL ensures that the TabSpecificContentSettings are not updated when
navigating same-page. This fixes an issue where the location tracking
icon would disappear when accepting to send location info to Google
search. This is because Google search would do a fragment navigation
when location tracking was accepted, which would fire DidStartNavigation
causing the location information to be reset. Previously,
DidStartProvisionalLoad would not be called for a fragment navigation,
so the icon would not be reset.

For the record, TabSpecificContentSettings was made to use DidStartNavigation
in https://codereview.chromium.org/2374443003.

BUG=667256
Review-Url: https://codereview.chromium.org/2524053002
Cr-Commit-Position: refs/heads/master@{#434208}
(cherry picked from commit d796bf464ffe66b896c8def42b1f916f62da9928)

Review URL: https://codereview.chromium.org/2534563002 .

Cr-Commit-Position: refs/branch-heads/2883@{#662}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
(cherry picked from commit fadbabf762310ae5d44221c37929dbf4807f5fe9)

Committed: https://chromium.googlesource.com/chromium/src/+/663c7917c9b2c91ade7de77568508012d24f36ce

[battre, 2017-01-04 11:53:33]

Description was changed from

==========
Don't update TabSpecificContentSettings on same-page navigation

This CL ensures that the TabSpecificContentSettings are not updated when
navigating same-page. This fixes an issue where the location tracking
icon would disappear when accepting to send location info to Google
search. This is because Google search would do a fragment navigation
when location tracking was accepted, which would fire DidStartNavigation
causing the location information to be reset. Previously,
DidStartProvisionalLoad would not be called for a fragment navigation,
so the icon would not be reset.

For the record, TabSpecificContentSettings was made to use DidStartNavigation
in https://codereview.chromium.org/2374443003.

BUG=667256

Review-Url: https://codereview.chromium.org/2524053002
Cr-Commit-Position: refs/heads/master@{#434208}
(cherry picked from commit d796bf464ffe66b896c8def42b1f916f62da9928)

Review URL: https://codereview.chromium.org/2534563002 .

Cr-Commit-Position: refs/branch-heads/2883@{#662}
Cr-Branched-From:
614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
(cherry picked from commit fadbabf762310ae5d44221c37929dbf4807f5fe9)
==========

to

==========
Don't update TabSpecificContentSettings on same-page navigation

This CL ensures that the TabSpecificContentSettings are not updated when
navigating same-page. This fixes an issue where the location tracking
icon would disappear when accepting to send location info to Google
search. This is because Google search would do a fragment navigation
when location tracking was accepted, which would fire DidStartNavigation
causing the location information to be reset. Previously,
DidStartProvisionalLoad would not be called for a fragment navigation,
so the icon would not be reset.

For the record, TabSpecificContentSettings was made to use DidStartNavigation
in https://codereview.chromium.org/2374443003.

BUG=667256

Review-Url: https://codereview.chromium.org/2524053002
Cr-Commit-Position: refs/heads/master@{#434208}
(cherry picked from commit d796bf464ffe66b896c8def42b1f916f62da9928)

Review URL: https://codereview.chromium.org/2534563002 .

Cr-Commit-Position: refs/branch-heads/2883@{#662}
Cr-Branched-From:
614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}
(cherry picked from commit fadbabf762310ae5d44221c37929dbf4807f5fe9)

Committed:
https://chromium.googlesource.com/chromium/src/+/663c7917c9b2c91ade7de7756850...
==========

[battre, 2017-01-04 11:53:35]

Committed patchset #1 (id:1) manually as
663c7917c9b2c91ade7de77568508012d24f36ce.