DescriptionDon't update TabSpecificContentSettings on same-page navigation
This CL ensures that the TabSpecificContentSettings are not updated when
navigating same-page. This fixes an issue where the location tracking
icon would disappear when accepting to send location info to Google
search. This is because Google search would do a fragment navigation
when location tracking was accepted, which would fire DidStartNavigation
causing the location information to be reset. Previously,
DidStartProvisionalLoad would not be called for a fragment navigation,
so the icon would not be reset.
For the record, TabSpecificContentSettings was made to use DidStartNavigation
in https://codereview.chromium.org/2374443003.
BUG=667256
Review-Url: https://codereview.chromium.org/2524053002
Cr-Commit-Position: refs/heads/master@{#434208}
(cherry picked from commit d796bf464ffe66b896c8def42b1f916f62da9928)
Committed: https://chromium.googlesource.com/chromium/src/+/fadbabf762310ae5d44221c37929dbf4807f5fe9
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|