Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2534563002: Don't update TabSpecificContentSettings on same-page navigation (Closed)

Created:
4 years ago by clamy
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. For the record, TabSpecificContentSettings was made to use DidStartNavigation in https://codereview.chromium.org/2374443003. BUG=667256 Review-Url: https://codereview.chromium.org/2524053002 Cr-Commit-Position: refs/heads/master@{#434208} (cherry picked from commit d796bf464ffe66b896c8def42b1f916f62da9928) Committed: https://chromium.googlesource.com/chromium/src/+/fadbabf762310ae5d44221c37929dbf4807f5fe9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
clamy
4 years ago (2016-11-25 09:59:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fadbabf762310ae5d44221c37929dbf4807f5fe9.

Powered by Google App Engine
This is Rietveld 408576698