Fix content settings's cookie code to work with PlzNavigate.

Fix content settings's cookie code to work with PlzNavigate.

There are two main fixes:
-use GetWebContentsGetter instead of the RPH/RFH IDs since the latter don't exist for browser side navigation
-switching TabSpecificContentSettings to use the new navigation callbacks. This is needed because with PlzNavigate, the old didstartprovisionalload callback (from the new renderer) would run after the cookie request (from the browser), and so we would wipe out the settings map. Using the new callbacks preserves the order of these callbacks with PlzNavigate.

This fixes the following browser tests with PlzNavigate:
ContentSettingsTest.RedirectCrossOrigin
ContentSettingsTest.RedirectLoopCookies

BUG=504347
Committed: https://crrev.com/092d3be76da7c2aef6a84e2791b5818a06cb4689
Cr-Commit-Position: refs/heads/master@{#421224}

[jam, 2016-09-26 21:18:43]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 21:19:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-26 21:22:46]

jam@chromium.org changed reviewers:
+ bauerb@chromium.org

[jam, 2016-09-26 21:23:07]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-09-26 22:11:08]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 22:12:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 22:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 22:54:10]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jam, 2016-09-26 23:06:13]

Patchset #1 (id:1) has been deleted

[Bernhard Bauer, 2016-09-27 09:27:50]

lgtm

https://codereview.chromium.org/2374443003/diff/20001/chrome/browser/content_...
File chrome/browser/content_settings/tab_specific_content_settings.cc (right):

https://codereview.chromium.org/2374443003/diff/20001/chrome/browser/content_...
chrome/browser/content_settings/tab_specific_content_settings.cc:57: namespace {
Nit: empty line after the opening namespace.

[jam, 2016-09-27 15:05:30]

https://codereview.chromium.org/2374443003/diff/20001/chrome/browser/content_...
File chrome/browser/content_settings/tab_specific_content_settings.cc (right):

https://codereview.chromium.org/2374443003/diff/20001/chrome/browser/content_...
chrome/browser/content_settings/tab_specific_content_settings.cc:57: namespace {
On 2016/09/27 09:27:49, Bernhard Bauer wrote:
> Nit: empty line after the opening namespace.

Done.

[jam, 2016-09-27 15:06:30]

The CQ bit was checked by jam@chromium.org

[jam, 2016-09-27 15:06:31]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2374443003/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-09-27 15:06:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:56:55]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-27 15:58:40]

Description was changed from

==========
Fix content settings's cookie code to work with PlzNavigate.

There are two main fixes:
-use GetWebContentsGetter instead of the RPH/RFH IDs since the latter don't
exist for browser side navigation
-switching TabSpecificContentSettings to use the new navigation callbacks. This
is needed because with PlzNavigate, the old didstartprovisionalload callback
(from the new renderer) would run after the cookie request (from the browser),
and so we would wipe out the settings map. Using the new callbacks preserves the
order of these callbacks with PlzNavigate.

This fixes the following browser tests with PlzNavigate:
ContentSettingsTest.RedirectCrossOrigin
ContentSettingsTest.RedirectLoopCookies

BUG=504347
==========

to

==========
Fix content settings's cookie code to work with PlzNavigate.

There are two main fixes:
-use GetWebContentsGetter instead of the RPH/RFH IDs since the latter don't
exist for browser side navigation
-switching TabSpecificContentSettings to use the new navigation callbacks. This
is needed because with PlzNavigate, the old didstartprovisionalload callback
(from the new renderer) would run after the cookie request (from the browser),
and so we would wipe out the settings map. Using the new callbacks preserves the
order of these callbacks with PlzNavigate.

This fixes the following browser tests with PlzNavigate:
ContentSettingsTest.RedirectCrossOrigin
ContentSettingsTest.RedirectLoopCookies

BUG=504347

Committed: https://crrev.com/092d3be76da7c2aef6a84e2791b5818a06cb4689
Cr-Commit-Position: refs/heads/master@{#421224}
==========

[commit-bot: I haz the power, 2016-09-27 15:58:43]

Patchset 2 (id:??) landed as
https://crrev.com/092d3be76da7c2aef6a84e2791b5818a06cb4689
Cr-Commit-Position: refs/heads/master@{#421224}