third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp - Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp b/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

index 5998bfb2a631ef9393e6a127350e9dc93998c094..a54de38ee4df0d414d6144ebe92c23c4ca407c10 100644

--- a/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

@@ -59,7 +59,8 @@ ScriptValue SQLResultSetRowList::item(ScriptState* scriptState,

Vector<std::pair<String, SQLValue>> dataArray;

for (unsigned i = 0; i < numColumns; ++i)

- dataArray.append(std::make_pair(m_columns[i], m_result[valuesIndex + i]));

+ dataArray.push_back(

+ std::make_pair(m_columns[i], m_result[valuesIndex + i]));

return ScriptValue::from(scriptState, dataArray);

}