third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.h - Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.h

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/Database.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.h

diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.h b/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.h

index 367f4d53d7b6af654525bf0c4f29ff8d5045c5ee..0e4cd17b0a5c2500c31177fe9eaa192a12b43676 100644

--- a/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.h

+++ b/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.h

@@ -51,8 +51,8 @@ class SQLResultSetRowList final

const Vector<String>& columnNames() const { return m_columns; }

const Vector<SQLValue>& values() const { return m_result; }

- void addColumn(const String& name) { m_columns.append(name); }

- void addResult(const SQLValue& result) { m_result.append(result); }

+ void addColumn(const String& name) { m_columns.push_back(name); }

+ void addResult(const SQLValue& result) { m_result.push_back(result); }

unsigned length() const;

ScriptValue item(ScriptState*, unsigned index, ExceptionState&);