third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp - Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007 Apple Inc. All rights reserved.	2 * Copyright (C) 2007 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 IndexSizeError, ExceptionMessages::indexExceedsMaximumBound<unsigned>(	52 IndexSizeError, ExceptionMessages::indexExceedsMaximumBound<unsigned>(

53 "index", index, length()));	53 "index", index, length()));

54 return ScriptValue();	54 return ScriptValue();

55 }	55 }

56	56

57 unsigned numColumns = m_columns.size();	57 unsigned numColumns = m_columns.size();

58 unsigned valuesIndex = index * numColumns;	58 unsigned valuesIndex = index * numColumns;

59	59

60 Vector<std::pair<String, SQLValue>> dataArray;	60 Vector<std::pair<String, SQLValue>> dataArray;

61 for (unsigned i = 0; i < numColumns; ++i)	61 for (unsigned i = 0; i < numColumns; ++i)

62 dataArray.append(std::make_pair(m_columns[i], m_result[valuesIndex + i]));	62 dataArray.push_back(

	63 std::make_pair(m_columns[i], m_result[valuesIndex + i]));

63	64

64 return ScriptValue::from(scriptState, dataArray);	65 return ScriptValue::from(scriptState, dataArray);

65 }	66 }

66	67

67 } // namespace blink	68 } // namespace blink

OLD	NEW