Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2614623004: Make Swarming bot keep 5%+250MB of the disk free. (Closed)

Created:
3 years, 11 months ago by Vadim Sh.
Modified:
3 years, 11 months ago
Reviewers:
dsansome
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Make Swarming bot keep 5%+250MB of the disk free. Also add more comments for disk self-quarantine thresholds definition, since they are somewhat confusing. This introduces a new knob, instead of tweaking self-quarantine knob, because: 1) We don't want to brick all bots that happen to have <5% && >4GB of free disk space. 2) We want to have some breathing room between desired free disk space and the disk space that triggers the quarantine. BUG=678404 R=dsansome@chromium.org Review-Url: https://codereview.chromium.org/2614623004 Committed: https://github.com/luci/luci-py/commit/e7fcbce2f8fcb01c3785d42278a913a33eb16356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -13 lines) Patch
M appengine/swarming/swarming_bot/api/os_utilities.py View 2 chunks +36 lines, -2 lines 0 comments Download
M appengine/swarming/swarming_bot/bot_code/bot_main.py View 3 chunks +5 lines, -9 lines 0 comments Download
M appengine/swarming/swarming_bot/bot_code/bot_main_test.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Vadim Sh.
3 years, 11 months ago (2017-01-05 01:29:16 UTC) #1
dsansome
lgtm
3 years, 11 months ago (2017-01-05 01:46:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614623004/1
3 years, 11 months ago (2017-01-05 01:47:03 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 01:51:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/e7fcbce2f8fcb01c3785d42278a913a33eb16356

Powered by Google App Engine
This is Rietveld 408576698