Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2224)

Unified Diff: appengine/swarming/swarming_bot/bot_code/bot_main.py

Issue 2614623004: Make Swarming bot keep 5%+250MB of the disk free. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/swarming_bot/bot_code/bot_main.py
diff --git a/appengine/swarming/swarming_bot/bot_code/bot_main.py b/appengine/swarming/swarming_bot/bot_code/bot_main.py
index 0ff2793ea0c63aab218d9d09b2c90c034170909a..8685edc155da2e8abcb216e6933a415ef1c571da 100644
--- a/appengine/swarming/swarming_bot/bot_code/bot_main.py
+++ b/appengine/swarming/swarming_bot/bot_code/bot_main.py
@@ -252,13 +252,9 @@ def is_base_dir_ok(botobj):
return botobj.base_dir != os.path.expanduser('~')
-def get_min_free_space(botobj):
- """Returns free disk space needed.
-
- Add a "250 MiB slack space" for logs, temporary files and whatever other leak.
- """
- return int(
- (os_utilities.get_min_free_space(botobj.base_dir) + 250.) * 1024 * 1024)
+def get_desired_free_space(botobj):
+ """Returns free disk space needed (in bytes)."""
+ return int(os_utilities.get_desired_free_space(botobj.base_dir) * 1024 * 1024)
def generate_version():
@@ -400,7 +396,7 @@ def clean_cache(botobj):
'--log-file', os.path.join(botobj.base_dir, 'logs', 'run_isolated.log'),
'--cache', os.path.join(botobj.base_dir, 'isolated_cache'),
'--named-cache-root', os.path.join(botobj.base_dir, 'c'),
- '--min-free-space', str(get_min_free_space(botobj)),
+ '--min-free-space', str(get_desired_free_space(botobj)),
]
logging.info('Running: %s', cmd)
try:
@@ -737,7 +733,7 @@ def run_manifest(botobj, manifest, start):
'--cost-usd-hour', str(botobj.state.get('cost_usd_hour') or 0.),
# Include the time taken to poll the task in the cost.
'--start', str(start),
- '--min-free-space', str(get_min_free_space(botobj)),
+ '--min-free-space', str(get_desired_free_space(botobj)),
'--bot-file', bot_file,
]
if botobj.remote.uses_auth:
« no previous file with comments | « appengine/swarming/swarming_bot/api/os_utilities.py ('k') | appengine/swarming/swarming_bot/bot_code/bot_main_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698