Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2614523002: Shorten some method names in //third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h (Closed)

Created:
3 years, 11 months ago by juncai
Modified:
3 years, 11 months ago
Reviewers:
scheib
CC:
chromium-reviews, blink-reviews, haraken, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shorten some method names in //third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h This is a follow-up CL for: https://codereview.chromium.org/2565913002/ Since the device is already a BluetoothDevice, the following methods at BluetoothDevice class can be renamed: getOrCreateBluetoothRemoteGATTService -> getOrCreateRemoteGATTService getOrCreateBluetoothRemoteGATTCharacteristic -> getOrCreateRemoteGATTCharacteristic BUG=676703, 597053 Committed: https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481 Cr-Commit-Position: refs/heads/master@{#441227}

Patch Set 1 : shorten some method names in //third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h #

Messages

Total messages: 14 (9 generated)
juncai
Please take a look.
3 years, 11 months ago (2017-01-03 20:39:00 UTC) #4
scheib
LGTM
3 years, 11 months ago (2017-01-03 22:36:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614523002/1
3 years, 11 months ago (2017-01-03 22:37:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 22:42:10 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 22:44:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481
Cr-Commit-Position: refs/heads/master@{#441227}

Powered by Google App Engine
This is Rietveld 408576698