third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp - Issue 2614523002: Shorten some method names in //third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

Issue 2614523002: Shorten some method names in //third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h (Closed)

Patch Set: shorten some method names in //third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

index 0b5bf81648383036e586b10dc4a6cee9baf761cc..5ac6a059bc0851ae095e44ae9d5484c48381c7e8 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

@@ -123,7 +123,7 @@ void BluetoothRemoteGATTServer::GetPrimaryServicesCallback(

if (quantity == mojom::blink::WebBluetoothGATTQueryQuantity::SINGLE) {

DCHECK_EQ(1u, services->size());

- resolver->resolve(m_device->getOrCreateBluetoothRemoteGATTService(

+ resolver->resolve(m_device->getOrCreateRemoteGATTService(

services.value()[0]->instance_id, services.value()[0]->uuid,

true /* isPrimary */, device()->id()));

return;

@@ -133,7 +133,7 @@ void BluetoothRemoteGATTServer::GetPrimaryServicesCallback(

gattServices.reserveInitialCapacity(services->size());

for (const auto& service : services.value()) {

- gattServices.append(m_device->getOrCreateBluetoothRemoteGATTService(

+ gattServices.append(m_device->getOrCreateRemoteGATTService(

service->instance_id, service->uuid, true /* isPrimary */,

device()->id()));

}