[Cronet] Use xcode clang on iOS to reduce release binary size.

[Cronet] Use xcode clang on iOS to reduce release binary size.

BUG=666502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2614423002
Cr-Commit-Position: refs/heads/master@{#471077}
Committed: https://chromium.googlesource.com/chromium/src/+/970e26717675d235f8dc59c1646e4abf9e3a7784

[mef, 2017-01-09 16:22:18]

Description was changed from

==========
[Cronet] Use xcode clang on iOS to reduce release binary size.

BUG=666502
==========

to

==========
[Cronet] Use xcode clang on iOS to reduce release binary size.

BUG=666502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mef, 2017-01-09 16:22:24]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 16:22:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2017-01-09 16:23:17]

mef@chromium.org changed reviewers:
+ kapishnikov@chromium.org

[mef, 2017-01-09 16:23:18]

PTAL

[commit-bot: I haz the power, 2017-01-09 17:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 17:28:03]

Dry run: This issue passed the CQ dry run.

[lilyhoughton, 2017-02-13 16:19:00]

lilyhoughton@chromium.org changed reviewers:
+ lilyhoughton@chromium.org

[lilyhoughton, 2017-02-13 16:19:01]

https://codereview.chromium.org/2614423002/diff/1/components/cronet/tools/cr_...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/2614423002/diff/1/components/cronet/tools/cr_...
components/cronet/tools/cr_cronet.py:84: 'use_xcode_clang=true '
Nit: it seems like elsewhere implicit string concatenation is used, instead of
with |+|.

[mef, 2017-05-09 21:31:53]

PTAL. I would like to land this and make corresponding changes to build bots.

Per conversation with Ping@ using Chromium Clang could cause crashes on older
devices. 

Per conversation with Sleevi@ we should set is_official_build=true for release
builds to apply proper optimizations.

https://codereview.chromium.org/2614423002/diff/1/components/cronet/tools/cr_...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/2614423002/diff/1/components/cronet/tools/cr_...
components/cronet/tools/cr_cronet.py:84: 'use_xcode_clang=true '
On 2017/02/13 16:19:01, lilyhoughton wrote:
> Nit: it seems like elsewhere implicit string concatenation is used, instead of
> with |+|.

Done.

[kapishnikov, 2017-05-10 17:43:28]

https://codereview.chromium.org/2614423002/diff/20001/components/cronet/tools...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/2614423002/diff/20001/components/cronet/tools...
components/cronet/tools/cr_cronet.py:84: 'is_official_build=true '
Should we build the developer's version by default? I guess
"is_official_build=true" is only needed for the release version to achieve the
higher level of optimization.

[mef, 2017-05-11 20:04:39]

Thanks, PTAL.

https://codereview.chromium.org/2614423002/diff/20001/components/cronet/tools...
File components/cronet/tools/cr_cronet.py (right):

https://codereview.chromium.org/2614423002/diff/20001/components/cronet/tools...
components/cronet/tools/cr_cronet.py:84: 'is_official_build=true '
On 2017/05/10 17:43:27, kapishnikov wrote:
> Should we build the developer's version by default? I guess
> "is_official_build=true" is only needed for the release version to achieve the
> higher level of optimization.

Done. Setting use_xcode_clang=true provides a reasonable approximation AND
supports goma which is nice.

[kapishnikov, 2017-05-11 20:40:12]

lgtm

[mef, 2017-05-11 20:55:54]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2017-05-11 20:56:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 21:27:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494536154352580,
"parent_rev": "a8da913d44ef4a4846ac31d5bc66dc253d5f150e", "commit_rev":
"970e26717675d235f8dc59c1646e4abf9e3a7784"}

[commit-bot: I haz the power, 2017-05-11 21:27:25]

Description was changed from

==========
[Cronet] Use xcode clang on iOS to reduce release binary size.

BUG=666502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Use xcode clang on iOS to reduce release binary size.

BUG=666502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2614423002
Cr-Commit-Position: refs/heads/master@{#471077}
Committed:
https://chromium.googlesource.com/chromium/src/+/970e26717675d235f8dc59c1646e...
==========

[commit-bot: I haz the power, 2017-05-11 21:27:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/970e26717675d235f8dc59c1646e...