components/cronet/tools/package_ios.py - Issue 2614423002: [Cronet] Use xcode clang on iOS to reduce release binary size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/package_ios.py

Issue 2614423002: [Cronet] Use xcode clang on iOS to reduce release binary size. (Closed)

Patch Set: Use_xcode_clang instead of is_official_build in cr_cronet.py. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/tools/package_ios.py

diff --git a/components/cronet/tools/package_ios.py b/components/cronet/tools/package_ios.py

index 829dec2edcfc792b431a6779ec1eb068da346d42..956d545b9c900d3751c12ec5cd7ef59bfadf6614 100755

--- a/components/cronet/tools/package_ios.py

+++ b/components/cronet/tools/package_ios.py

@@ -90,8 +90,8 @@ def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''):

# Package all builds in the output directory

os.makedirs(out_dir)

build_dir = ''

- for (build_config, gn_extra_args) in [('Debug', 'is_debug=true'),

- ('Release', 'is_debug=false enable_stripping=true')]:

+ for (build_config, gn_extra_args) in [('Debug', 'is_debug=true use_xcode_clang=true'),

+ ('Release', 'is_debug=false enable_stripping=true is_official_build=true')]:

for (target_device, target_cpu, additional_cpu) in [('os', 'arm', 'arm64'),

('simulator', 'x86', 'x64')]:

target_dir = '%s-iphone%s' % (build_config, target_device)

« no previous file with comments | « components/cronet/tools/cr_cronet.py ('k') | no next file » | no next file with comments »