Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

This browser test was disabled for being flaky; the app menu would not always
open when it was supposed to. This change makes the test wait for the app menu
to open before continuing.

BUG=658005
Review-Url: https://codereview.chromium.org/2614413003
Cr-Commit-Position: refs/heads/master@{#442680}
Committed: https://chromium.googlesource.com/chromium/src/+/d9689efb8f5509310872a90a9654b9592cba2d19

[takumif, 2017-01-09 21:42:02]

Description was changed from

==========
Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

BUG=658005
==========

to

==========
Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

This browser test was disabled for being flaky; the app menu would not always
open when it was supposed to. This change makes the test wait for the app menu
to open before continuing.

BUG=658005
==========

[takumif, 2017-01-09 21:42:48]

Description was changed from

==========
Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

This browser test was disabled for being flaky; the app menu would not always
open when it was supposed to. This change makes the test wait for the app menu
to open before continuing.

BUG=658005
==========

to

==========
Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

This browser test was disabled for being flaky; the app menu would not always
open when it was supposed to. This change makes the test wait for the app menu
to open before continuing.

BUG=658005
==========

[takumif, 2017-01-09 21:45:07]

takumif@chromium.org changed reviewers:
+ apacible@chromium.org

[takumif, 2017-01-09 21:45:08]

Please take a look, thanks!
Before this patch, the test would fail once every 10 to 20 times. I ran the test
100 times with the patch without failing.

[apacible, 2017-01-10 18:30:38]

lgtm

[takumif, 2017-01-10 18:33:37]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 18:34:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 19:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 19:34:28]

Dry run: This issue passed the CQ dry run.

[takumif, 2017-01-10 20:40:45]

The CQ bit was checked by takumif@chromium.org

[commit-bot: I haz the power, 2017-01-10 20:41:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 20:46:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484080845221950,
"parent_rev": "42968739363fbecc9515b3631d2e05ac7046fb02", "commit_rev":
"d9689efb8f5509310872a90a9654b9592cba2d19"}

[commit-bot: I haz the power, 2017-01-10 20:46:49]

Description was changed from

==========
Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

This browser test was disabled for being flaky; the app menu would not always
open when it was supposed to. This change makes the test wait for the app menu
to open before continuing.

BUG=658005
==========

to

==========
Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

This browser test was disabled for being flaky; the app menu would not always
open when it was supposed to. This change makes the test wait for the app menu
to open before continuing.

BUG=658005

Review-Url: https://codereview.chromium.org/2614413003
Cr-Commit-Position: refs/heads/master@{#442680}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9689efb8f5509310872a90a9654...
==========

[commit-bot: I haz the power, 2017-01-10 20:46:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9689efb8f5509310872a90a9654...