Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7741)

Unified Diff: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Issue 2614413003: Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction (Closed)
Patch Set: Remove TODO comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
diff --git a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
index cdd01b6488d6d62564198c48a52aeeeec765f1b3..7455c4bfd6e2c40cfbe6e125c0f8a24ad518d9a6 100644
--- a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
+++ b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
@@ -69,7 +69,10 @@ class MediaRouterUIBrowserTest : public InProcessBrowserTest {
FROM_HERE,
base::Bind(&MediaRouterUIBrowserTest::ExecuteMediaRouterAction,
base::Unretained(this), app_menu_button));
+
+ base::RunLoop run_loop;
app_menu_button->ShowMenu(false);
+ run_loop.RunUntilIdle();
nav_observer.Wait();
EXPECT_FALSE(app_menu_button->IsMenuShowing());
@@ -113,9 +116,8 @@ class MediaRouterUIBrowserTest : public InProcessBrowserTest {
MediaRouterActionController* action_controller_ = nullptr;
};
-// TODO(crbug.com/658005): Fails on multiple platforms.
IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest,
- DISABLED_OpenDialogWithMediaRouterAction) {
+ OpenDialogWithMediaRouterAction) {
// We start off at about:blank page.
// Make sure there is 1 tab and media router is enabled.
ASSERT_EQ(1, browser()->tab_strip_model()->count());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698