Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2614373002: [FeedbackVector] Infrastructure for literal arrays in the vector. (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[FeedbackVector] Infrastructure for literal arrays in the vector. This changes the NewClosure interface descriptor, but ignores the additional vector/slot arguments for now. The feedback vector gets larger, as it holds a space for each literal array. A follow-on CL will constructively use this space. BUG=v8:5456 Review-Url: https://codereview.chromium.org/2614373002 Cr-Commit-Position: refs/heads/master@{#42146} Committed: https://chromium.googlesource.com/v8/v8/+/38602f1ff553b32815d34a05cd6d965f4fc20960

Patch Set 1 #

Patch Set 2 : Ensure we don't allocate extra literal arrays. #

Patch Set 3 : REBASE. #

Patch Set 4 : Release compile fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -178 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ast/ast.h View 1 2 4 chunks +27 lines, -0 lines 0 comments Download
M src/ast/ast-numbering.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-constructor.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins/builtins-constructor.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/js-operator.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M src/factory.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 4 chunks +12 lines, -2 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/interface-descriptors.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 2 2 chunks +13 lines, -5 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 3 1 chunk +10 lines, -6 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/type-feedback-vector.h View 1 2 10 chunks +44 lines, -4 lines 0 comments Download
M src/type-feedback-vector.cc View 1 2 12 chunks +83 lines, -6 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 2 2 chunks +28 lines, -1 line 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BasicLoops.golden View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 1 2 14 chunks +22 lines, -22 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CompoundExpressions.golden View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextParameters.golden View 5 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextVariables.golden View 7 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CountOperators.golden View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DeclareGlobals.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Delete.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/FunctionLiterals.golden View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariableContextSlot.golden View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden View 1 2 9 chunks +17 lines, -17 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TopLevelObjectLiterals.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-create-lowering-unittest.cc View 1 2 2 chunks +16 lines, -3 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
mvstanton
Hi Benedikt, Here is the *partial* re-land of the literal array change we've discussed. This ...
3 years, 11 months ago (2017-01-09 13:08:04 UTC) #7
Benedikt Meurer
LGTM.
3 years, 11 months ago (2017-01-09 13:46:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614373002/60001
3 years, 11 months ago (2017-01-09 14:51:38 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 15:31:06 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/38602f1ff553b32815d34a05cd6d965f4fc...

Powered by Google App Engine
This is Rietveld 408576698