Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2614333002: Revert of Create vector icon resource directory specific to Chrome. (Closed)

Created:
3 years, 11 months ago by vitaliii
Modified:
3 years, 11 months ago
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Create vector icon resource directory specific to Chrome. (patchset #7 id:140001 of https://codereview.chromium.org/2610163003/ ) Reason for revert: Speculative revert, likely broke: Linux: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/31040 Mac: https://uberchromegw.corp.google.com/i/chromium/builders/Mac/builds/22402 BUG=679272 Original issue's description: > Create vector icon resource directory specific to Chrome. > > BUG=626786 > > Review-Url: https://codereview.chromium.org/2610163003 > Cr-Commit-Position: refs/heads/master@{#442183} > Committed: https://chromium.googlesource.com/chromium/src/+/8283cad74e0cad4840d1f222052d2244136ffeda TBR=oshima@chromium.org,tdanderson@chromium.org,sky@chromium.org,avi@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626786 Review-Url: https://codereview.chromium.org/2614333002 Cr-Commit-Position: refs/heads/master@{#442212} Committed: https://chromium.googlesource.com/chromium/src/+/0c2a3a29a5ad22d423151a835bc67582395870c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -518 lines) Patch
D chrome/app/vector_icons/BUILD.gn View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/app/vector_icons/browser_tools.icon View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/app/vector_icons/browser_tools_error.icon View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/app/vector_icons/browser_tools_update.icon View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/app/vector_icons/navigate_back.icon View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/app/vector_icons/navigate_back.1x.icon View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/app/vector_icons/navigate_forward.icon View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/app/vector_icons/navigate_forward.1x.icon View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/app/vector_icons/navigate_home.icon View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/app/vector_icons/navigate_home.1x.icon View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/app/vector_icons/navigate_reload.icon View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/app/vector_icons/navigate_reload.1x.icon View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/app/vector_icons/navigate_stop.icon View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/app/vector_icons/navigate_stop.1x.icon View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/app/vector_icons/vector_icons.cc.template View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/app/vector_icons/vector_icons.h.template View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/recovery/recovery_install_global_error.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm View 4 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/ui/global_error/global_error.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_views_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/toolbar/reload_button.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/upgrade_detector.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/vector_icons/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/browser_tools.icon View 1 chunk +24 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/browser_tools_error.icon View 1 chunk +22 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/browser_tools_update.icon View 1 chunk +19 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_back.icon View 1 chunk +27 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_back.1x.icon View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_forward.icon View 1 chunk +27 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_forward.1x.icon View 1 chunk +27 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_home.icon View 1 chunk +37 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_home.1x.icon View 1 chunk +32 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_reload.icon View 1 chunk +27 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_reload.1x.icon View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_stop.icon View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/navigate_stop.1x.icon View 1 chunk +23 lines, -0 lines 0 comments Download
M ui/views/controls/button/vector_icon_button.h View 3 chunks +1 line, -8 lines 0 comments Download
M ui/views/controls/button/vector_icon_button.cc View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vitaliii
Created Revert of Create vector icon resource directory specific to Chrome.
3 years, 11 months ago (2017-01-09 08:50:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614333002/1
3 years, 11 months ago (2017-01-09 08:50:58 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 08:52:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c2a3a29a5ad22d423151a835bc6...

Powered by Google App Engine
This is Rietveld 408576698