Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 2614063005: Revert of cros: Small visual tweaks for material design palette. (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
stevenjb, jdufault
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cros: Small visual tweaks for material design palette. (patchset #2 id:20001 of https://codereview.chromium.org/2608343002/ ) Reason for revert: Fails to build on Linux ChromiumOS Builder (dbg) since SkColorSetARGB is not a constexpr function Original issue's description: > cros: Small visual tweaks for material design palette. > > BUG=678034 > > Review-Url: https://codereview.chromium.org/2608343002 > Cr-Commit-Position: refs/heads/master@{#441800} > Committed: https://chromium.googlesource.com/chromium/src/+/9abb5f3f351b0d3831f79da9980a00db4d7d4815 TBR=stevenjb@chromium.org,jdufault@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678034 Review-Url: https://codereview.chromium.org/2614063005 Cr-Commit-Position: refs/heads/master@{#441858} Committed: https://chromium.googlesource.com/chromium/src/+/c808c7c92eb71b4d529bf00b3a65a012e2962c99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M ash/common/system/chromeos/palette/common_palette_tool.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 3 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dcheng
Created Revert of cros: Small visual tweaks for material design palette.
3 years, 11 months ago (2017-01-06 03:04:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614063005/1
3 years, 11 months ago (2017-01-06 03:05:15 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 03:06:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c808c7c92eb71b4d529bf00b3a65...

Powered by Google App Engine
This is Rietveld 408576698