cros: Small visual tweaks for material design palette.

cros: Small visual tweaks for material design palette.

BUG=678034
Review-Url: https://codereview.chromium.org/2608343002
Cr-Commit-Position: refs/heads/master@{#441800}
Committed: https://chromium.googlesource.com/chromium/src/+/9abb5f3f351b0d3831f79da9980a00db4d7d4815

[jdufault, 2017-01-03 19:27:34]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 19:27:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 19:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 19:58:07]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-04 18:22:07]

Description was changed from

==========
cros: Small visual tweaks for material design palette.

BUG=678034
==========

to

==========
cros: Small visual tweaks for material design palette.

BUG=678034
==========

[jdufault, 2017-01-04 18:22:07]

jdufault@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jdufault, 2017-01-04 18:23:51]

stevenjb@ PTAL. tdanderson@ is OOO for another week.

[stevenjb, 2017-01-04 18:27:34]

lgtm

https://codereview.chromium.org/2608343002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2608343002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/palette/palette_tray.cc:58: const int
kPalettePaddingOnBottom = 2;
nit: change all of these to use constexpr while you are in here.

[jdufault, 2017-01-04 20:45:32]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 20:45:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 21:13:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 21:13:26]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-05 22:35:39]

https://codereview.chromium.org/2608343002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2608343002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/palette/palette_tray.cc:58: const int
kPalettePaddingOnBottom = 2;
On 2017/01/04 18:27:34, stevenjb wrote:
> nit: change all of these to use constexpr while you are in here.

Done.

[jdufault, 2017-01-05 22:35:43]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-01-05 22:35:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2608343002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-01-05 22:36:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 01:42:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483655743344260,
"parent_rev": "5513e4622febbc838dfebddb51347ab797747836", "commit_rev":
"9abb5f3f351b0d3831f79da9980a00db4d7d4815"}

[commit-bot: I haz the power, 2017-01-06 01:43:25]

Description was changed from

==========
cros: Small visual tweaks for material design palette.

BUG=678034
==========

to

==========
cros: Small visual tweaks for material design palette.

BUG=678034

Review-Url: https://codereview.chromium.org/2608343002
Cr-Commit-Position: refs/heads/master@{#441800}
Committed:
https://chromium.googlesource.com/chromium/src/+/9abb5f3f351b0d3831f79da9980a...
==========

[commit-bot: I haz the power, 2017-01-06 01:43:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9abb5f3f351b0d3831f79da9980a...

[dcheng, 2017-01-06 03:04:50]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2614063005/ by dcheng@chromium.org.

The reason for reverting is: Fails to build on Linux ChromiumOS Builder (dbg)
since SkColorSetARGB is not a constexpr function.

[dcheng, 2017-01-06 03:06:17]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2017-01-06 03:06:18]

https://codereview.chromium.org/2608343002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2608343002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:66: SkColorSetARGB(0x1E,
0x00, 0x00, 0x00);
This breaks if NDEBUG isn't true, since this uses an inline function in debug
mode, and the function isn't marked constexpr:

../../ash/common/system/chromeos/palette/palette_tray.cc:65:19: error: constexpr
variable 'kPaletteSeparatorColor' must be initialized by a constant expression
constexpr SkColor kPaletteSeparatorColor =
                  ^
../../ash/common/system/chromeos/palette/palette_tray.cc:66:5: note:
non-constexpr function 'SkColorSetARGBInline' cannot be used in a constant
expression
    SkColorSetARGB(0x1E, 0x00, 0x00, 0x00);
    ^
../../third_party/skia/include/core/SkColor.h:53:36: note: expanded from macro
'SkColorSetARGB'
#define SkColorSetARGB(a, r, g, b) SkColorSetARGBInline(a, r, g, b)
                                   ^
../../third_party/skia/include/core/SkColor.h:32:23: note: declared here
static inline SkColor SkColorSetARGBInline(U8CPU a, U8CPU r, U8CPU g, U8CPU b)

[sashab, 2017-01-06 03:06:51]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2614663010/ by sashab@chromium.org.

The reason for reverting is: Causes compile failure on:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

[1904/11789] CXX obj/ash/ash/palette_tray.o
FAILED: obj/ash/ash/palette_tray.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/ash/ash/palette_tray.o.d -DASH_IMPLEMENTATION
-DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1
-DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
-DUSE_X11=1 -DENABLE_WAYLAND_SERVER=1 -DUSE_PROPRIETARY_CODECS
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-DCR_CLANG_REVISION=289944-2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-DCOMPONENT_BUILD -DOS_CHROMEOS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1 -DGL_GLEXT_PROTOTYPES
-DUSE_GLX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DSK_IGNORE_DW_GRAY_FIX
-DSK_LEGACY_FONTMGR_FACTORY -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DU_USING_ICU_NAMESPACE=0
-DU_ENABLE_DYLOAD=0 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE
-DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD
-DPROTOBUF_USE_DLLS -DBORINGSSL_SHARED_LIBRARY -DUSING_V8_SHARED -I../.. -Igen
-I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/glib-2.0
-I../../build/linux/ubuntu_precise_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I../../third_party/khronos -I../../gpu -Igen/ash/common/strings
-Igen/ash/resources -I../../skia/config -I../../skia/ext
-I../../third_party/skia/include/c -I../../third_party/skia/include/config
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/images -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu
-I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl
-I../../third_party/ced/src -I../../third_party/icu/source/common
-I../../third_party/icu/source/i18n
-I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/dbus-1.0
-I../../build/linux/ubuntu_precise_amd64-sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include
-I../../third_party/protobuf/src -Igen/protoc_out
-I../../third_party/protobuf/src -I../../third_party/libwebm/source
-I../../third_party/boringssl/src/include
-I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/nss
-I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/nspr
-I../../third_party/mesa/src/include -I../../third_party/WebKit
-Igen/third_party/WebKit -I../../v8/include -Igen/v8/include
-I../../third_party/qcms/src -Igen -Igen/ui/views/resources
-Igen/ui/chromeos/resources -Igen/ui/chromeos/strings -Igen/ui/resources
-Igen/ui/resources -fno-strict-aliasing -funwind-tables -fPIC -pipe
-B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics
-fdebug-prefix-map=/b/c/b/linux_chromeos/src=. -m64 -march=x86-64 -pthread -Wall
-Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter
-Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-address-of-packed-member -O0
-fno-omit-frame-pointer -g2 -gsplit-dwarf
--sysroot=../../build/linux/ubuntu_precise_amd64-sysroot -fvisibility=hidden
-Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-ipc -Wheader-hygiene -Wstring-conversion
-Wtautological-overlap-compare -Wno-header-guard -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare -std=gnu++11
-Wno-reserved-user-defined-literal -fno-rtti -fno-exceptions -c
../../ash/common/system/chromeos/palette/palette_tray.cc -o
obj/ash/ash/palette_tray.o
../../ash/common/system/chromeos/palette/palette_tray.cc:65:19: error: constexpr
variable 'kPaletteSeparatorColor' must be initialized by a constant expression
constexpr SkColor kPaletteSeparatorColor =
                  ^
../../ash/common/system/chromeos/palette/palette_tray.cc:66:5: note:
non-constexpr function 'SkColorSetARGBInline' cannot be used in a constant
expression
    SkColorSetARGB(0x1E, 0x00, 0x00, 0x00);
    ^
../../third_party/skia/include/core/SkColor.h:53:36: note: expanded from macro
'SkColorSetARGB'
#define SkColorSetARGB(a, r, g, b) SkColorSetARGBInline(a, r, g, b)
                                   ^
../../third_party/skia/include/core/SkColor.h:32:23: note: declared here
static inline SkColor SkColorSetARGBInline(U8CPU a, U8CPU r, U8CPU g, U8CPU b)
                      ^
1 error generated..

[findit-for-me, 2017-01-06 03:13:41]

FYI: Findit identified this CL at revision 441800 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...