Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2614063004: MD Settings: re-use some iron-flex-layout classes to shrink checkboxes -> toggles diff (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: re-use some iron-flex-layout classes to shrink checkboxes -> toggles diff R=dschuyler@chromium.org BUG=673953 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2614063004 Cr-Commit-Position: refs/heads/master@{#442153} Committed: https://chromium.googlesource.com/chromium/src/+/1314396d75b72f1d0676f97fd8d39b59f6bbb3ba

Patch Set 1 : found another one #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 5 chunks +4 lines, -10 lines 0 comments Download
M chrome/test/data/webui/settings/metrics_reporting_tests.js View 5 chunks +5 lines, -5 lines 1 comment Download

Messages

Total messages: 14 (9 generated)
Dan Beam
3 years, 11 months ago (2017-01-06 02:32:13 UTC) #3
Dan Beam
ping
3 years, 11 months ago (2017-01-07 00:47:52 UTC) #8
dschuyler
lgtm https://codereview.chromium.org/2614063004/diff/20001/chrome/test/data/webui/settings/metrics_reporting_tests.js File chrome/test/data/webui/settings/metrics_reporting_tests.js (right): https://codereview.chromium.org/2614063004/diff/20001/chrome/test/data/webui/settings/metrics_reporting_tests.js#newcode53 chrome/test/data/webui/settings/metrics_reporting_tests.js:53: assertFalse(!!page.$$('#restart')); Nice.
3 years, 11 months ago (2017-01-07 02:56:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614063004/20001
3 years, 11 months ago (2017-01-07 02:57:06 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 04:26:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1314396d75b72f1d0676f97fd8d3...

Powered by Google App Engine
This is Rietveld 408576698