Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4959)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2614063004: MD Settings: re-use some iron-flex-layout classes to shrink checkboxes -> toggles diff (Closed)
Patch Set: found another one Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 76fbc1a6c0e2478739786f2f0e2aaaa92c3220c6..a1c41586f0f84358274412185167554830dfeb9d 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -38,12 +38,7 @@
background-image: url(../images/help_outline.svg);
}
- /* TODO(dbeam): this is similar to a 1 line checkbox. Worth somehow
- * combining? */
- #metricsReporting,
- #safeBrowsingExtendedReporting {
- align-items: center;
- display: flex;
+ .settings-row-min-height {
min-height: var(--settings-row-min-height);
}
@@ -66,7 +61,6 @@
}
#restart {
- flex: 1;
text-align: end;
}
</style>
@@ -90,7 +84,7 @@
label="$i18n{networkPredictionEnabled}"
hidden="[[!pageVisibility.networkPrediction]]">
</settings-checkbox>
- <div id="safeBrowsingExtendedReporting">
+ <div class="layout horizontal center settings-row-min-height">
<paper-checkbox id="safeBrowsingExtendedReportingCheckbox"
on-tap="onSafeBrowsingExtendedReportingCheckboxTap_"
checked="[[safeBrowsingExtendedReportingEnabled_]]">
@@ -107,7 +101,7 @@
</settings-checkbox>
</if><!-- chromeos -->
<if expr="not chromeos">
- <div id="metricsReporting">
+ <div class="layout horizontal center settings-row-min-height">
<paper-checkbox id="metricsReportingCheckbox"
on-tap="onMetricsReportingCheckboxTap_"
checked="[[metricsReporting_.enabled]]"
@@ -122,7 +116,7 @@
</paper-tooltip>
</template>
<template is="dom-if" if="[[showRestart_]]" restamp>
- <div id="restart">
+ <div id="restart" class="flex">
<paper-button on-tap="onRestartTap_">
$i18n{restart}
</paper-button>

Powered by Google App Engine
This is Rietveld 408576698