Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2614023006: [ios] Removed -[CRWWebDelegate openURLWithParams:]. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed -[CRWWebDelegate openURLWithParams:]. Replaced this method with WebStateDelegate::OpenURLFromWebState which mirrors WebContentsDelegate::OpenURLFromTab. BUG=674991 Review-Url: https://codereview.chromium.org/2614023006 Cr-Commit-Position: refs/heads/master@{#442275} Committed: https://chromium.googlesource.com/chromium/src/+/75a06fa7347a84e1e2f1261e30b0f7dfa7b70971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -33 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 chunk +0 lines, -28 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 3 chunks +41 lines, -0 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/public/web_state/web_state_delegate.h View 2 chunks +6 lines, -1 line 0 comments Download
M ios/web/public/web_state/web_state_delegate_bridge.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_delegate.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_delegate_bridge.mm View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_delegate_bridge_unittest.mm View 2 chunks +27 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_delegate_stub.h View 1 chunk +4 lines, -1 line 0 comments Download
M ios/web/web_state/web_state_delegate_stub.mm View 3 chunks +13 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-07 02:24:13 UTC) #6
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-09 09:52:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614023006/1
3 years, 11 months ago (2017-01-09 16:54:45 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 17:10:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75a06fa7347a84e1e2f1261e30b0...

Powered by Google App Engine
This is Rietveld 408576698