Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: ios/web/web_state/web_state_delegate_bridge_unittest.mm

Issue 2614023006: [ios] Removed -[CRWWebDelegate openURLWithParams:]. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/web_state_delegate_bridge.mm ('k') | ios/web/web_state/web_state_delegate_stub.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/web_state_delegate_bridge_unittest.mm
diff --git a/ios/web/web_state/web_state_delegate_bridge_unittest.mm b/ios/web/web_state/web_state_delegate_bridge_unittest.mm
index fa1754d9d6cc861449532e786b15e5ea1bb38455..9d882e20edfb0e48c89fbad5a56f8207a81aefb5 100644
--- a/ios/web/web_state/web_state_delegate_bridge_unittest.mm
+++ b/ios/web/web_state/web_state_delegate_bridge_unittest.mm
@@ -8,10 +8,12 @@
#import "base/mac/scoped_nsobject.h"
#include "base/strings/utf_string_conversions.h"
+#import "ios/web/public/test/fakes/test_web_state.h"
#import "ios/web/public/web_state/context_menu_params.h"
#import "ios/web/web_state/web_state_delegate_stub.h"
#include "testing/platform_test.h"
#import "third_party/ocmock/gtest_support.h"
+#include "ui/base/page_transition_types.h"
namespace web {
@@ -36,8 +38,33 @@ class WebStateDelegateBridgeTest : public PlatformTest {
base::scoped_nsprotocol<id> delegate_;
std::unique_ptr<WebStateDelegateBridge> bridge_;
+ web::TestWebState test_web_state_;
};
+// Tests |webState:openURLWithParams:| forwarding.
+TEST_F(WebStateDelegateBridgeTest, OpenURLFromWebState) {
+ ASSERT_FALSE([delegate_ webState]);
+ ASSERT_FALSE([delegate_ openURLParams]);
+
+ web::WebState::OpenURLParams params(
+ GURL("https://chromium.test/"),
+ web::Referrer(GURL("https://chromium2.test/"), ReferrerPolicyNever),
+ WindowOpenDisposition::NEW_WINDOW, ui::PAGE_TRANSITION_FORM_SUBMIT, true);
+ EXPECT_EQ(&test_web_state_,
+ bridge_->OpenURLFromWebState(&test_web_state_, params));
+
+ EXPECT_EQ(&test_web_state_, [delegate_ webState]);
+ const web::WebState::OpenURLParams* result_params = [delegate_ openURLParams];
+ ASSERT_TRUE(result_params);
+ EXPECT_EQ(params.url, result_params->url);
+ EXPECT_EQ(params.referrer.url, result_params->referrer.url);
+ EXPECT_EQ(params.referrer.policy, result_params->referrer.policy);
+ EXPECT_EQ(params.disposition, result_params->disposition);
+ EXPECT_EQ(static_cast<int>(params.transition),
+ static_cast<int>(result_params->transition));
+ EXPECT_EQ(params.is_renderer_initiated, result_params->is_renderer_initiated);
+}
+
// Tests |LoadProgressChanged| forwarding.
TEST_F(WebStateDelegateBridgeTest, LoadProgressChanged) {
ASSERT_EQ(0.0, [delegate_ changedProgress]);
« no previous file with comments | « ios/web/web_state/web_state_delegate_bridge.mm ('k') | ios/web/web_state/web_state_delegate_stub.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698