Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2613863005: Removes/promotes functions from WmWindowMus to WmWindowAura (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes/promotes functions from WmWindowMus to WmWindowAura The remaining functions are rather specific to aura-mus, will tackle them next. BUG=671246 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2613863005 Cr-Commit-Position: refs/heads/master@{#441815} Committed: https://chromium.googlesource.com/chromium/src/+/ebb8e6536246b3b9a0b0529c94e70a7118dc8e08

Patch Set 1 #

Total comments: 2

Patch Set 2 : window_ #

Patch Set 3 : window_ part2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -99 lines) Patch
M ash/aura/wm_window_aura.cc View 1 2 6 chunks +30 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.h View 1 chunk +0 lines, -15 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 2 chunks +0 lines, -79 lines 0 comments Download
M ash/wm/window_util.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
sky
3 years, 11 months ago (2017-01-05 21:32:04 UTC) #1
James Cook
LGTM with nit https://codereview.chromium.org/2613863005/diff/1/ash/aura/wm_window_aura.cc File ash/aura/wm_window_aura.cc (right): https://codereview.chromium.org/2613863005/diff/1/ash/aura/wm_window_aura.cc#newcode353 ash/aura/wm_window_aura.cc:353: aura_window()->GetProperty(kShelfItemTypeKey) != TYPE_UNDEFINED) { nit: just ...
3 years, 11 months ago (2017-01-05 23:16:48 UTC) #6
sky
https://codereview.chromium.org/2613863005/diff/1/ash/aura/wm_window_aura.cc File ash/aura/wm_window_aura.cc (right): https://codereview.chromium.org/2613863005/diff/1/ash/aura/wm_window_aura.cc#newcode353 ash/aura/wm_window_aura.cc:353: aura_window()->GetProperty(kShelfItemTypeKey) != TYPE_UNDEFINED) { On 2017/01/05 23:16:47, James Cook ...
3 years, 11 months ago (2017-01-05 23:30:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613863005/20001
3 years, 11 months ago (2017-01-05 23:31:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613863005/40001
3 years, 11 months ago (2017-01-05 23:58:56 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:01:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ebb8e6536246b3b9a0b0529c94e7...

Powered by Google App Engine
This is Rietveld 408576698