Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2611253002: Removes some dead code (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes some dead code I also removed some ifdefs that are no longer necessary and some windows code that isn't needed. BUG=671246 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2611253002 Cr-Commit-Position: refs/heads/master@{#441963} Committed: https://chromium.googlesource.com/chromium/src/+/4ec2be8dc762f1398c2bb0f3cb278d05269d3067

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -156 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/display/window_tree_host_manager.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 9 chunks +8 lines, -17 lines 0 comments Download
M ash/host/ash_window_tree_host.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/host/ash_window_tree_host.cc View 3 chunks +0 lines, -20 lines 0 comments Download
D ash/host/ash_window_tree_host_win.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ash/host/ash_window_tree_host_win.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/shell.h View 4 chunks +1 line, -7 lines 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
sky
3 years, 11 months ago (2017-01-06 00:43:43 UTC) #1
James Cook
LGTM
3 years, 11 months ago (2017-01-06 01:24:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611253002/20001
3 years, 11 months ago (2017-01-06 16:22:01 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 17:39:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ec2be8dc762f1398c2bb0f3cb27...

Powered by Google App Engine
This is Rietveld 408576698