Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2613793002: Removes/promotes functions from WmWindowMus to WmWindowAura (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes/promotes functions from WmWindowMus to WmWindowAura The aura implementation for many of these can be used as is. BUG=671246 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2613793002 Cr-Commit-Position: refs/heads/master@{#441689} Committed: https://chromium.googlesource.com/chromium/src/+/307e3589d858c808490ec46f5dad414a97b1a544

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : move WmWindowAuraTestApi to ash/test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -315 lines) Patch
M ash/aura/wm_window_aura.h View 5 chunks +17 lines, -1 line 0 comments Download
M ash/aura/wm_window_aura.cc View 1 7 chunks +24 lines, -9 lines 0 comments Download
M ash/common/wm_window.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/BUILD.gn View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 3 chunks +0 lines, -8 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 3 chunks +0 lines, -17 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.h View 5 chunks +0 lines, -60 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 1 7 chunks +10 lines, -107 lines 0 comments Download
D ash/mus/bridge/wm_window_mus_test_api.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ash/mus/bridge/wm_window_mus_test_api.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M ash/mus/non_client_frame_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/mus/test/wm_test_base.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ash/mus/test/wm_test_base.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + ash/test/wm_window_aura_test_api.h View 1 2 3 chunks +11 lines, -13 lines 0 comments Download
A ash/test/wm_window_aura_test_api.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M ash/wm/window_properties.h View 2 chunks +19 lines, -0 lines 0 comments Download
M ash/wm/window_properties.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
sky
I'm hoping to remove all overrides in WmWindowMus, but this is a good starting point.
3 years, 11 months ago (2017-01-05 00:00:01 UTC) #2
James Cook
LGTM but please move the test api files. https://codereview.chromium.org/2613793002/diff/20001/ash/mus/BUILD.gn File ash/mus/BUILD.gn (right): https://codereview.chromium.org/2613793002/diff/20001/ash/mus/BUILD.gn#newcode216 ash/mus/BUILD.gn:216: "bridge/wm_window_aura_test_api.cc", ...
3 years, 11 months ago (2017-01-05 02:50:10 UTC) #6
sky
Can you take another look at the BUILD.gn changes to make sure you are ok ...
3 years, 11 months ago (2017-01-05 16:17:01 UTC) #7
James Cook
LGTM
3 years, 11 months ago (2017-01-05 16:36:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613793002/40001
3 years, 11 months ago (2017-01-05 16:38:29 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:31:00 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/307e3589d858c808490ec46f5dad...

Powered by Google App Engine
This is Rietveld 408576698