Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2613723002: [runtime] Use DCHECK_EQ instead of DCHECK for number of args. (Closed)

Created:
3 years, 11 months ago by Franzi
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Use DCHECK_EQ instead of DCHECK for number of args. BUG= Review-Url: https://codereview.chromium.org/2613723002 Cr-Commit-Position: refs/heads/master@{#42083} Committed: https://chromium.googlesource.com/v8/v8/+/b371b0b7e7c7ab83aeea1306581ddebfa37a3b00

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -341 lines) Patch
M src/runtime/runtime-array.cc View 15 chunks +16 lines, -16 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 11 chunks +14 lines, -14 lines 0 comments Download
M src/runtime/runtime-collections.cc View 26 chunks +27 lines, -27 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 50 chunks +51 lines, -51 lines 0 comments Download
M src/runtime/runtime-error.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M src/runtime/runtime-futex.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-generator.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 22 chunks +22 lines, -22 lines 0 comments Download
M src/runtime/runtime-internal.cc View 15 chunks +19 lines, -19 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-module.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M src/runtime/runtime-object.cc View 23 chunks +23 lines, -23 lines 0 comments Download
M src/runtime/runtime-promise.cc View 1 11 chunks +12 lines, -12 lines 0 comments Download
M src/runtime/runtime-proxy.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-simd.cc View 16 chunks +16 lines, -16 lines 0 comments Download
M src/runtime/runtime-strings.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M src/runtime/runtime-symbol.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 31 chunks +32 lines, -32 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 10 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Franzi
Hi Benedikt, Since DCHECKs that compare numbers always require additional work to see the actual ...
3 years, 11 months ago (2017-01-04 13:43:24 UTC) #4
Jarin
lgtm
3 years, 11 months ago (2017-01-04 14:23:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613723002/1
3 years, 11 months ago (2017-01-05 07:30:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31706)
3 years, 11 months ago (2017-01-05 07:34:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613723002/120001
3 years, 11 months ago (2017-01-05 07:54:30 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 08:22:21 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/b371b0b7e7c7ab83aeea1306581ddebfa37...

Powered by Google App Engine
This is Rietveld 408576698