Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/runtime/runtime-symbol.cc

Issue 2613723002: [runtime] Use DCHECK_EQ instead of DCHECK for number of args. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime-strings.cc ('k') | src/runtime/runtime-test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/isolate-inl.h" 8 #include "src/isolate-inl.h"
9 #include "src/objects-inl.h" 9 #include "src/objects-inl.h"
10 #include "src/string-builder.h" 10 #include "src/string-builder.h"
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 14
15 RUNTIME_FUNCTION(Runtime_CreateSymbol) { 15 RUNTIME_FUNCTION(Runtime_CreateSymbol) {
16 HandleScope scope(isolate); 16 HandleScope scope(isolate);
17 DCHECK(args.length() == 1); 17 DCHECK_EQ(1, args.length());
18 CONVERT_ARG_HANDLE_CHECKED(Object, name, 0); 18 CONVERT_ARG_HANDLE_CHECKED(Object, name, 0);
19 CHECK(name->IsString() || name->IsUndefined(isolate)); 19 CHECK(name->IsString() || name->IsUndefined(isolate));
20 Handle<Symbol> symbol = isolate->factory()->NewSymbol(); 20 Handle<Symbol> symbol = isolate->factory()->NewSymbol();
21 if (name->IsString()) symbol->set_name(*name); 21 if (name->IsString()) symbol->set_name(*name);
22 return *symbol; 22 return *symbol;
23 } 23 }
24 24
25 25
26 RUNTIME_FUNCTION(Runtime_CreatePrivateSymbol) { 26 RUNTIME_FUNCTION(Runtime_CreatePrivateSymbol) {
27 HandleScope scope(isolate); 27 HandleScope scope(isolate);
28 DCHECK(args.length() == 1); 28 DCHECK_EQ(1, args.length());
29 CONVERT_ARG_HANDLE_CHECKED(Object, name, 0); 29 CONVERT_ARG_HANDLE_CHECKED(Object, name, 0);
30 CHECK(name->IsString() || name->IsUndefined(isolate)); 30 CHECK(name->IsString() || name->IsUndefined(isolate));
31 Handle<Symbol> symbol = isolate->factory()->NewPrivateSymbol(); 31 Handle<Symbol> symbol = isolate->factory()->NewPrivateSymbol();
32 if (name->IsString()) symbol->set_name(*name); 32 if (name->IsString()) symbol->set_name(*name);
33 return *symbol; 33 return *symbol;
34 } 34 }
35 35
36 36
37 RUNTIME_FUNCTION(Runtime_SymbolDescription) { 37 RUNTIME_FUNCTION(Runtime_SymbolDescription) {
38 SealHandleScope shs(isolate); 38 SealHandleScope shs(isolate);
39 DCHECK(args.length() == 1); 39 DCHECK_EQ(1, args.length());
40 CONVERT_ARG_CHECKED(Symbol, symbol, 0); 40 CONVERT_ARG_CHECKED(Symbol, symbol, 0);
41 return symbol->name(); 41 return symbol->name();
42 } 42 }
43 43
44 44
45 RUNTIME_FUNCTION(Runtime_SymbolDescriptiveString) { 45 RUNTIME_FUNCTION(Runtime_SymbolDescriptiveString) {
46 HandleScope scope(isolate); 46 HandleScope scope(isolate);
47 DCHECK_EQ(1, args.length()); 47 DCHECK_EQ(1, args.length());
48 CONVERT_ARG_HANDLE_CHECKED(Symbol, symbol, 0); 48 CONVERT_ARG_HANDLE_CHECKED(Symbol, symbol, 0);
49 IncrementalStringBuilder builder(isolate); 49 IncrementalStringBuilder builder(isolate);
50 builder.AppendCString("Symbol("); 50 builder.AppendCString("Symbol(");
51 if (symbol->name()->IsString()) { 51 if (symbol->name()->IsString()) {
52 builder.AppendString(handle(String::cast(symbol->name()), isolate)); 52 builder.AppendString(handle(String::cast(symbol->name()), isolate));
53 } 53 }
54 builder.AppendCharacter(')'); 54 builder.AppendCharacter(')');
55 RETURN_RESULT_OR_FAILURE(isolate, builder.Finish()); 55 RETURN_RESULT_OR_FAILURE(isolate, builder.Finish());
56 } 56 }
57 57
58 58
59 RUNTIME_FUNCTION(Runtime_SymbolIsPrivate) { 59 RUNTIME_FUNCTION(Runtime_SymbolIsPrivate) {
60 SealHandleScope shs(isolate); 60 SealHandleScope shs(isolate);
61 DCHECK(args.length() == 1); 61 DCHECK_EQ(1, args.length());
62 CONVERT_ARG_CHECKED(Symbol, symbol, 0); 62 CONVERT_ARG_CHECKED(Symbol, symbol, 0);
63 return isolate->heap()->ToBoolean(symbol->is_private()); 63 return isolate->heap()->ToBoolean(symbol->is_private());
64 } 64 }
65 } // namespace internal 65 } // namespace internal
66 } // namespace v8 66 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime-strings.cc ('k') | src/runtime/runtime-test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698