Hook up proper FocusController for simple_wm.

Hook up proper FocusController for simple_wm.

Note also the change made to CustomFrameView. Seems odd that this issue exists there after all these years. Maybe I should be making that change somewhere else?

R=sky@chromium.org

Committed: https://crrev.com/949663e209bdaf6eca72f01cc797a8684ecfa4ac
Cr-Commit-Position: refs/heads/master@{#441285}

[Ben Goodger (Google), 2017-01-03 22:20:36]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 22:21:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-03 23:52:34]

My guess on the repaint issue is we likely trigger repaint along some other path
as well, so no one noticed.

https://codereview.chromium.org/2613613002/diff/1/mash/simple_wm/simple_wm.cc
File mash/simple_wm/simple_wm.cc (right):

https://codereview.chromium.org/2613613002/diff/1/mash/simple_wm/simple_wm.cc...
mash/simple_wm/simple_wm.cc:564: return window == window_root_;
Shouldn't you only return true if window is in client_window_to_frame_view_?

[Ben Goodger (Google), 2017-01-03 23:54:40]

https://codereview.chromium.org/2613613002/diff/1/mash/simple_wm/simple_wm.cc
File mash/simple_wm/simple_wm.cc (right):

https://codereview.chromium.org/2613613002/diff/1/mash/simple_wm/simple_wm.cc...
mash/simple_wm/simple_wm.cc:564: return window == window_root_;
On 2017/01/03 23:52:34, sky wrote:
> Shouldn't you only return true if window is in client_window_to_frame_view_?

The window passed to this function is the parent of the window being activated,
which is the outer (frame view) window.

[sky, 2017-01-04 00:09:58]

LGTM

https://codereview.chromium.org/2613613002/diff/1/mash/simple_wm/simple_wm.cc
File mash/simple_wm/simple_wm.cc (right):

https://codereview.chromium.org/2613613002/diff/1/mash/simple_wm/simple_wm.cc...
mash/simple_wm/simple_wm.cc:564: return window == window_root_;
On 2017/01/03 23:54:40, Ben Goodger (Google) wrote:
> On 2017/01/03 23:52:34, sky wrote:
> > Shouldn't you only return true if window is in client_window_to_frame_view_?
> 
> The window passed to this function is the parent of the window being
activated,
> which is the outer (frame view) window.

Ah, got it.

[commit-bot: I haz the power, 2017-01-04 00:48:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 00:48:24]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2017-01-04 01:24:03]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2017-01-04 01:24:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 01:33:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483493043755720, "parent_rev":
"a8233f47b4b3b023711826da04b0d0e9a63513a6", "commit_rev":
"adeeec193e04bb54b92ddcf1bab5f4ef7affac33"}

[commit-bot: I haz the power, 2017-01-04 01:33:58]

Description was changed from

==========
Hook up proper FocusController for simple_wm.

Note also the change made to CustomFrameView. Seems odd that this issue exists
there after all these years. Maybe I should be making that change somewhere
else?

R=sky@chromium.org
==========

to

==========
Hook up proper FocusController for simple_wm.

Note also the change made to CustomFrameView. Seems odd that this issue exists
there after all these years. Maybe I should be making that change somewhere
else?

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2613613002
==========

[commit-bot: I haz the power, 2017-01-04 01:33:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-04 01:38:20]

Description was changed from

==========
Hook up proper FocusController for simple_wm.

Note also the change made to CustomFrameView. Seems odd that this issue exists
there after all these years. Maybe I should be making that change somewhere
else?

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2613613002
==========

to

==========
Hook up proper FocusController for simple_wm.

Note also the change made to CustomFrameView. Seems odd that this issue exists
there after all these years. Maybe I should be making that change somewhere
else?

R=sky@chromium.org

Committed: https://crrev.com/949663e209bdaf6eca72f01cc797a8684ecfa4ac
Cr-Commit-Position: refs/heads/master@{#441285}
==========

[commit-bot: I haz the power, 2017-01-04 01:38:21]

Patchset 1 (id:??) landed as
https://crrev.com/949663e209bdaf6eca72f01cc797a8684ecfa4ac
Cr-Commit-Position: refs/heads/master@{#441285}