Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2613553002:
DevTools: Fix compiling with debug_devtools flag (Closed)
DescriptionDevTools: Fix compiling with DebugDevtools flag
BUG=554289
Committed: https://crrev.com/1754d896b46c9e52c50eaeb18f7c39ce68b146d5
Cr-Commit-Position: refs/heads/master@{#441215}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== DevTools: Fix compiling with DebugDevtools flag BUG= ========== to ========== DevTools: Fix compiling with DebugDevtools flag BUG=554289 ==========
This was broken by https://codereview.chromium.org/2608103002
einbinder@chromium.org changed reviewers: + avi@chromium.org, jam@chromium.org
ptal
lgtm Yes, thank you. Sorry for missing that one.
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1483479732192160, "parent_rev":
"2243955198d574e70d5030e82c12c807326d20de", "commit_rev":
"fe83df5ca2c26da9a88f07a76f67604c45cf5bff"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: Fix compiling with DebugDevtools flag BUG=554289 ========== to ========== DevTools: Fix compiling with DebugDevtools flag BUG=554289 Review-Url: https://codereview.chromium.org/2613553002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: Fix compiling with DebugDevtools flag BUG=554289 Review-Url: https://codereview.chromium.org/2613553002 ========== to ========== DevTools: Fix compiling with DebugDevtools flag BUG=554289 Committed: https://crrev.com/1754d896b46c9e52c50eaeb18f7c39ce68b146d5 Cr-Commit-Position: refs/heads/master@{#441215} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1754d896b46c9e52c50eaeb18f7c39ce68b146d5 Cr-Commit-Position: refs/heads/master@{#441215} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
