Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2608103002: Remove ScopedVector from URLRequestInterceptorScopedVector. (Closed)

Created:
3 years, 11 months ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, lcwu+watch_chromium.org, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, halliwell+watch_chromium.org, Peter Beverloo, wjmaclean, alokp+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, sdefresne+watch_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, pkl (ping after 24h if needed), steimel+watch-blimp_chromium.org, android-webview-reviews_chromium.org, perumaal+watch-blimp_chromium.org, noyau+watch_chromium.org, dtrainor+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from URLRequestInterceptorScopedVector. BUG=554289 Committed: https://crrev.com/c18097c72cc6dcb4fa95c5f5fb0f7ee32e901601 Cr-Commit-Position: refs/heads/master@{#441146}

Patch Set 1 #

Patch Set 2 : ios #

Patch Set 3 : aw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -76 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 2 2 chunks +6 lines, -10 lines 0 comments Download
M blimp/engine/app/blimp_url_request_context_getter.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/public/browser/browser_context.h View 4 chunks +9 lines, -9 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.cc View 1 chunk +1 line, -8 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ios/chrome/browser/net/net_types.h View 2 chunks +7 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (17 generated)
Avi (use Gerrit)
John, can you take a look?
3 years, 11 months ago (2017-01-02 02:06:13 UTC) #12
jam
lgtm
3 years, 11 months ago (2017-01-03 16:37:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608103002/40001
3 years, 11 months ago (2017-01-03 16:42:03 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-03 17:39:13 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 17:41:17 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c18097c72cc6dcb4fa95c5f5fb0f7ee32e901601
Cr-Commit-Position: refs/heads/master@{#441146}

Powered by Google App Engine
This is Rietveld 408576698