MD History: Move flaky focus tests into interactive UI tests

MD History: Move flaky focus tests into interactive UI tests

MD History has several tests which test how focus reacts to keyboard
shortcuts. These have been flaky in browser tests, failing most of the
time when run in parallel with other browser tests. This CL attempts to
restore these tests by moving them to interactive UI tests, where
they should always be run one at a time.

These are the first interactive UI tests which run tests in a WebUI
page, so several test files have been moved in the build to accommodate
this.

BUG=642467
Review-Url: https://codereview.chromium.org/2613503004
Cr-Commit-Position: refs/heads/master@{#443122}
Committed: https://chromium.googlesource.com/chromium/src/+/bd856e843b236c65c916b86be2a32288cc0bebd5

[tsergeant, 2017-01-05 03:14:25]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 03:15:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 03:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 03:52:14]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[tsergeant, 2017-01-06 01:49:47]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:50:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:56:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:56:05]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[tsergeant, 2017-01-09 00:38:58]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 00:39:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 01:21:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 01:21:13]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-09 03:33:56]

Patchset #4 (id:60001) has been deleted

[tsergeant, 2017-01-09 03:34:02]

Patchset #4 (id:80001) has been deleted

[tsergeant, 2017-01-09 03:34:11]

Patchset #1 (id:1) has been deleted

[tsergeant, 2017-01-09 03:34:55]

Patchset #2 (id:40001) has been deleted

[tsergeant, 2017-01-09 03:35:00]

Patchset #1 (id:20001) has been deleted

[tsergeant, 2017-01-09 03:35:07]

Patchset #1 (id:100001) has been deleted

[tsergeant, 2017-01-09 03:40:02]

Description was changed from

==========
MD History: Move flaky focus tests into interactive UI tests

MD History has several tests which test how focus reacts to keyboard
shortcuts. These have been flaky in browser tests, failing most of the
time when run in parallel with other browser tests. This CL attempts to
restore these tests by moving them to an interactive UI tests, where
they should always be run serially in the foreground.

BUG=642467
==========

to

==========
MD History: Move flaky focus tests into interactive UI tests

MD History has several tests which test how focus reacts to keyboard
shortcuts. These have been flaky in browser tests, failing most of the
time when run in parallel with other browser tests. This CL attempts to
restore these tests by moving them to interactive UI tests, where
they should always be run one at a time.

These are the first interactive UI tests which run tests in a WebUI
page, so several test files have been moved in the build to accommodate
this.

BUG=642467
==========

[tsergeant, 2017-01-09 03:45:59]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 03:46:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 04:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 04:24:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2017-01-09 04:29:57]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 04:30:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 08:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 08:47:58]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-10 00:40:14]

Patchset #2 (id:140001) has been deleted

[tsergeant, 2017-01-10 23:09:00]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 23:09:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:04:01]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-11 03:11:24]

Patchset #1 (id:120001) has been deleted

[tsergeant, 2017-01-11 03:18:05]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[tsergeant, 2017-01-11 03:18:06]

Please take a look! The tests seem to work fine locally and on the try bots

[Dan Beam, 2017-01-11 05:34:24]

lgtm but is there some other set of tests you could piggyback onto instead?

[tsergeant, 2017-01-11 05:41:00]

I'm not really sure what you mean? I'm not aware of anything else in interactive
ui tests which does something similar to this.

[Dan Beam, 2017-01-11 06:03:10]

On 2017/01/11 05:41:00, tsergeant wrote:
> I'm not really sure what you mean? I'm not aware of anything else in
interactive
> ui tests which does something similar to this.

this is what I was thinking about, but i guess it's not .js
https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?q=interactive_ui_te...

[tsergeant, 2017-01-11 23:26:55]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:27:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:36:51]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1484177215597130,
"parent_rev": "3a06f2645235a7de84376c6615553957e49d0563", "commit_rev":
"bd856e843b236c65c916b86be2a32288cc0bebd5"}

[commit-bot: I haz the power, 2017-01-12 02:37:20]

Description was changed from

==========
MD History: Move flaky focus tests into interactive UI tests

MD History has several tests which test how focus reacts to keyboard
shortcuts. These have been flaky in browser tests, failing most of the
time when run in parallel with other browser tests. This CL attempts to
restore these tests by moving them to interactive UI tests, where
they should always be run one at a time.

These are the first interactive UI tests which run tests in a WebUI
page, so several test files have been moved in the build to accommodate
this.

BUG=642467
==========

to

==========
MD History: Move flaky focus tests into interactive UI tests

MD History has several tests which test how focus reacts to keyboard
shortcuts. These have been flaky in browser tests, failing most of the
time when run in parallel with other browser tests. This CL attempts to
restore these tests by moving them to interactive UI tests, where
they should always be run one at a time.

These are the first interactive UI tests which run tests in a WebUI
page, so several test files have been moved in the build to accommodate
this.

BUG=642467

Review-Url: https://codereview.chromium.org/2613503004
Cr-Commit-Position: refs/heads/master@{#443122}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd856e843b236c65c916b86be2a3...
==========

[commit-bot: I haz the power, 2017-01-12 02:37:21]

Committed patchset #2 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/bd856e843b236c65c916b86be2a3...