Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2438)

Unified Diff: chrome/test/data/webui/md_history/history_list_test.js

Issue 2613503004: MD History: Move flaky focus tests into interactive UI tests (Closed)
Patch Set: Remove unnecessary (?) dep Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | chrome/test/data/webui/md_history/history_synced_tabs_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/md_history/history_list_test.js
diff --git a/chrome/test/data/webui/md_history/history_list_test.js b/chrome/test/data/webui/md_history/history_list_test.js
index c2709836e5b31d054c693ea095db48e63afbd9df..39873325c4047b55d449a0c594826551a77183c7 100644
--- a/chrome/test/data/webui/md_history/history_list_test.js
+++ b/chrome/test/data/webui/md_history/history_list_test.js
@@ -479,61 +479,6 @@ suite('<history-list>', function() {
});
});
- // Test is very flaky on all platforms, http://crbug.com/669227.
- test.skip('focus and keyboard nav', function(done) {
- app.historyResult(createHistoryInfo(), TEST_HISTORY_RESULTS);
- PolymerTest.flushTasks().then(function() {
- var items = polymerSelectAll(element, 'history-item');
-
- var focused = items[2].$.checkbox;
- focused.focus();
-
- // Wait for next render to ensure that focus handlers have been
- // registered (see HistoryItemElement.attached).
- Polymer.RenderStatus.afterNextRender(this, function() {
- MockInteractions.pressAndReleaseKeyOn(
- focused, 39, [], 'ArrowRight');
- focused = items[2].$.title;
- assertEquals(focused, element.lastFocused_);
- assertTrue(items[2].row_.isActive());
- assertFalse(items[3].row_.isActive());
-
- MockInteractions.pressAndReleaseKeyOn(focused, 40, [], 'ArrowDown');
- focused = items[3].$.title;
- assertEquals(focused, element.lastFocused_);
- assertFalse(items[2].row_.isActive());
- assertTrue(items[3].row_.isActive());
-
- MockInteractions.pressAndReleaseKeyOn(
- focused, 39, [], 'ArrowRight');
- focused = items[3].$['menu-button'];
- assertEquals(focused, element.lastFocused_);
- assertFalse(items[2].row_.isActive());
- assertTrue(items[3].row_.isActive());
-
- MockInteractions.pressAndReleaseKeyOn(focused, 38, [], 'ArrowUp');
- focused = items[2].$['menu-button'];
- assertEquals(focused, element.lastFocused_);
- assertTrue(items[2].row_.isActive());
- assertFalse(items[3].row_.isActive());
-
- MockInteractions.pressAndReleaseKeyOn(focused, 37, [], 'ArrowLeft');
- focused = items[2].$$('#bookmark-star');
- assertEquals(focused, element.lastFocused_);
- assertTrue(items[2].row_.isActive());
- assertFalse(items[3].row_.isActive());
-
- MockInteractions.pressAndReleaseKeyOn(focused, 40, [], 'ArrowDown');
- focused = items[3].$.title;
- assertEquals(focused, element.lastFocused_);
- assertFalse(items[2].row_.isActive());
- assertTrue(items[3].row_.isActive());
-
- done();
- });
- });
- });
-
teardown(function() {
registerMessageCallback('removeVisits', this, undefined);
registerMessageCallback('queryHistory', this, function() {});
« no previous file with comments | « chrome/test/BUILD.gn ('k') | chrome/test/data/webui/md_history/history_synced_tabs_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698