android: Use ScreenInfo to calculate tile size

android: Use ScreenInfo to calculate tile size

This removes the dependency on deprecated DeviceDisplayInfo.
Try to emulate previous logic, though the physical dimension computed
from ScreenInfo has rounding errors, so it's not exact.

Note for perf sheriffs: this may have device-specific perf impact.

BUG=625089
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_blink_rel

Review-Url: https://codereview.chromium.org/2613303002
Cr-Commit-Position: refs/heads/master@{#442490}
Committed: https://chromium.googlesource.com/chromium/src/+/6f8ab17a9400e5c22a19baec33d744658cde0496

[boliu, 2017-01-06 20:15:01]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 20:15:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:30:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[boliu, 2017-01-06 22:49:45]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 22:50:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-01-06 23:13:47]

The CQ bit was unchecked by boliu@chromium.org

[boliu, 2017-01-06 23:14:29]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 23:14:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 00:19:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 00:19:10]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-01-07 00:21:57]

boliu@chromium.org changed reviewers:
+ aelias@chromium.org

[boliu, 2017-01-07 00:21:57]

ptal at content/renderer

Fallback to use fuzzy heuristics in content/renderer because the computed
display size does have rounding errors. seems not worth the big effort to make
this perfect. wdyt?

[aelias_OOO_until_Jul13, 2017-01-09 22:40:24]

lgtm

[boliu, 2017-01-09 22:53:54]

boliu@chromium.org changed reviewers:
+ khushalsagar@chromium.org, sky@chromium.org

[boliu, 2017-01-09 22:53:55]

+sky for content/test
+khushalsagar for blimp <- mostly just made the same changes, but from Display

[sky, 2017-01-10 00:00:27]

LGTM

[Khushal, 2017-01-10 00:07:59]

lgtm

[boliu, 2017-01-10 00:17:40]

Description was changed from

==========
android: Use ScreenInfo to calculate tile size

This removes the dependency on deprecated DeviceDisplayInfo.
Try to emulate previous logic, though the physical dimension computed
from ScreenInfo has rounding errors, so it's not exact.

Note for perf sheriffs: this may have device-specific perf impact.

BUG=625089
==========

to

==========
android: Use ScreenInfo to calculate tile size

This removes the dependency on deprecated DeviceDisplayInfo.
Try to emulate previous logic, though the physical dimension computed
from ScreenInfo has rounding errors, so it's not exact.

Note for perf sheriffs: this may have device-specific perf impact.

BUG=625089
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_blink_rel
==========

[boliu, 2017-01-10 00:31:17]

fyi I had to make blimp depend on display in BUILD.gn as well

[boliu, 2017-01-10 00:49:07]

The CQ bit was checked by boliu@chromium.org

[boliu, 2017-01-10 00:49:07]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
sky@chromium.org, khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2613303002/#ps80001
(title: "blimp deps")

[commit-bot: I haz the power, 2017-01-10 00:50:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 02:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 02:15:11]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[boliu, 2017-01-10 02:25:32]

err, blimp unit tests don't initialize screen/display. Since blimp is in the
process of being removed, I just deleted the blimp code in question instead.
Khushal, wanna stamp again?

[boliu, 2017-01-10 02:25:43]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 02:26:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Khushal, 2017-01-10 02:28:20]

lgtm again. All this code is going to go away soon anway so this is better.

[boliu, 2017-01-10 02:28:51]

The CQ bit was unchecked by boliu@chromium.org

[boliu, 2017-01-10 02:28:55]

The CQ bit was checked by boliu@chromium.org

[boliu, 2017-01-10 02:28:56]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2613303002/#ps100001
(title: "delete blimp")

[commit-bot: I haz the power, 2017-01-10 02:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 05:06:49]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484015335631320,
"parent_rev": "fead49e2fd15801c992d66e9fd17642da17a0fbd", "commit_rev":
"6f8ab17a9400e5c22a19baec33d744658cde0496"}

[commit-bot: I haz the power, 2017-01-10 05:07:33]

Description was changed from

==========
android: Use ScreenInfo to calculate tile size

This removes the dependency on deprecated DeviceDisplayInfo.
Try to emulate previous logic, though the physical dimension computed
from ScreenInfo has rounding errors, so it's not exact.

Note for perf sheriffs: this may have device-specific perf impact.

BUG=625089
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_blink_rel
==========

to

==========
android: Use ScreenInfo to calculate tile size

This removes the dependency on deprecated DeviceDisplayInfo.
Try to emulate previous logic, though the physical dimension computed
from ScreenInfo has rounding errors, so it's not exact.

Note for perf sheriffs: this may have device-specific perf impact.

BUG=625089
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_blink_rel

Review-Url: https://codereview.chromium.org/2613303002
Cr-Commit-Position: refs/heads/master@{#442490}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f8ab17a9400e5c22a19baec33d7...
==========

[commit-bot: I haz the power, 2017-01-10 05:07:35]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6f8ab17a9400e5c22a19baec33d7...