Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: content/browser/media/session/audio_focus_delegate_android.cc

Issue 2613143003: [MediaSession] Keep MediaSession controllable when losing audio focus (Closed)
Patch Set: suppress FB warnings Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/audio_focus_delegate_android.cc
diff --git a/content/browser/media/session/audio_focus_delegate_android.cc b/content/browser/media/session/audio_focus_delegate_android.cc
index dfaba7d1588f001685927deaef243d030285d94d..07f0a8e515860ab0b82fb763e1df460e23892ce3 100644
--- a/content/browser/media/session/audio_focus_delegate_android.cc
+++ b/content/browser/media/session/audio_focus_delegate_android.cc
@@ -53,19 +53,11 @@ void AudioFocusDelegateAndroid::AbandonAudioFocus() {
}
void AudioFocusDelegateAndroid::OnSuspend(JNIEnv*,
- const JavaParamRef<jobject>&,
- jboolean temporary) {
- // TODO(mlamouri): this check makes it so that if a MediaSession is paused and
- // then loses audio focus, it will still stay in the Suspended state.
- // See https://crbug.com/539998
+ const JavaParamRef<jobject>&) {
if (!media_session_->IsActive())
return;
- if (temporary) {
- media_session_->Suspend(MediaSession::SuspendType::SYSTEM);
- } else {
- media_session_->Stop(MediaSession::SuspendType::SYSTEM);
- }
+ media_session_->Suspend(MediaSession::SuspendType::SYSTEM);
}
void AudioFocusDelegateAndroid::OnResume(JNIEnv*,

Powered by Google App Engine
This is Rietveld 408576698