content/public/android/java/src/org/chromium/content/browser/AudioFocusDelegate.java - Issue 2613143003: [MediaSession] Keep MediaSession controllable when losing audio focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/AudioFocusDelegate.java

Issue 2613143003: [MediaSession] Keep MediaSession controllable when losing audio focus (Closed)

Patch Set: suppress FB warnings Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/session/audio_focus_delegate_android.cc ('k') | content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/AudioFocusDelegate.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/AudioFocusDelegate.java b/content/public/android/java/src/org/chromium/content/browser/AudioFocusDelegate.java

index ad03a3abae5f804de63dff0863f594c167fc8e6c..26424336afc4f57ed80559d3b27cad789110e17e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/AudioFocusDelegate.java

+++ b/content/public/android/java/src/org/chromium/content/browser/AudioFocusDelegate.java

@@ -90,7 +90,7 @@ public class AudioFocusDelegate implements AudioManager.OnAudioFocusChangeListen

}

break;

case AudioManager.AUDIOFOCUS_LOSS_TRANSIENT:

- nativeOnSuspend(mNativeAudioFocusDelegateAndroid, true);

+ nativeOnSuspend(mNativeAudioFocusDelegateAndroid);

break;

case AudioManager.AUDIOFOCUS_LOSS_TRANSIENT_CAN_DUCK:

mIsDucking = true;

@@ -99,7 +99,7 @@ public class AudioFocusDelegate implements AudioManager.OnAudioFocusChangeListen

break;

case AudioManager.AUDIOFOCUS_LOSS:

abandonAudioFocus();

- nativeOnSuspend(mNativeAudioFocusDelegateAndroid, false);

+ nativeOnSuspend(mNativeAudioFocusDelegateAndroid);

break;

default:

Log.w(TAG, "onAudioFocusChange called with unexpected value %d", focusChange);

@@ -107,7 +107,7 @@ public class AudioFocusDelegate implements AudioManager.OnAudioFocusChangeListen

}

- private native void nativeOnSuspend(long nativeAudioFocusDelegateAndroid, boolean temporary);

+ private native void nativeOnSuspend(long nativeAudioFocusDelegateAndroid);

private native void nativeOnResume(long nativeAudioFocusDelegateAndroid);

private native void nativeOnStartDucking(long nativeAudioFocusDelegateAndroid);

private native void nativeOnStopDucking(long nativeAudioFocusDelegateAndroid);