Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: content/browser/media/session/audio_focus_delegate_android.cc

Issue 2613143003: [MediaSession] Keep MediaSession controllable when losing audio focus (Closed)
Patch Set: suppress FB warnings Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/media/session/audio_focus_delegate_android.h" 5 #include "content/browser/media/session/audio_focus_delegate_android.h"
6 6
7 #include "base/android/context_utils.h" 7 #include "base/android/context_utils.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "content/browser/media/session/media_session_impl.h" 9 #include "content/browser/media/session/media_session_impl.h"
10 #include "jni/AudioFocusDelegate_jni.h" 10 #include "jni/AudioFocusDelegate_jni.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 AudioFocusManager::AudioFocusType::GainTransientMayDuck); 46 AudioFocusManager::AudioFocusType::GainTransientMayDuck);
47 } 47 }
48 48
49 void AudioFocusDelegateAndroid::AbandonAudioFocus() { 49 void AudioFocusDelegateAndroid::AbandonAudioFocus() {
50 JNIEnv* env = base::android::AttachCurrentThread(); 50 JNIEnv* env = base::android::AttachCurrentThread();
51 DCHECK(env); 51 DCHECK(env);
52 Java_AudioFocusDelegate_abandonAudioFocus(env, j_media_session_delegate_); 52 Java_AudioFocusDelegate_abandonAudioFocus(env, j_media_session_delegate_);
53 } 53 }
54 54
55 void AudioFocusDelegateAndroid::OnSuspend(JNIEnv*, 55 void AudioFocusDelegateAndroid::OnSuspend(JNIEnv*,
56 const JavaParamRef<jobject>&, 56 const JavaParamRef<jobject>&) {
57 jboolean temporary) {
58 // TODO(mlamouri): this check makes it so that if a MediaSession is paused and
59 // then loses audio focus, it will still stay in the Suspended state.
60 // See https://crbug.com/539998
61 if (!media_session_->IsActive()) 57 if (!media_session_->IsActive())
62 return; 58 return;
63 59
64 if (temporary) { 60 media_session_->Suspend(MediaSession::SuspendType::SYSTEM);
65 media_session_->Suspend(MediaSession::SuspendType::SYSTEM);
66 } else {
67 media_session_->Stop(MediaSession::SuspendType::SYSTEM);
68 }
69 } 61 }
70 62
71 void AudioFocusDelegateAndroid::OnResume(JNIEnv*, 63 void AudioFocusDelegateAndroid::OnResume(JNIEnv*,
72 const JavaParamRef<jobject>&) { 64 const JavaParamRef<jobject>&) {
73 if (!media_session_->IsReallySuspended()) 65 if (!media_session_->IsReallySuspended())
74 return; 66 return;
75 67
76 media_session_->Resume(MediaSession::SuspendType::SYSTEM); 68 media_session_->Resume(MediaSession::SuspendType::SYSTEM);
77 } 69 }
78 70
(...skipping 14 matching lines...) Expand all
93 // static 85 // static
94 std::unique_ptr<AudioFocusDelegate> AudioFocusDelegate::Create( 86 std::unique_ptr<AudioFocusDelegate> AudioFocusDelegate::Create(
95 MediaSessionImpl* media_session) { 87 MediaSessionImpl* media_session) {
96 AudioFocusDelegateAndroid* delegate = 88 AudioFocusDelegateAndroid* delegate =
97 new AudioFocusDelegateAndroid(media_session); 89 new AudioFocusDelegateAndroid(media_session);
98 delegate->Initialize(); 90 delegate->Initialize();
99 return std::unique_ptr<AudioFocusDelegate>(delegate); 91 return std::unique_ptr<AudioFocusDelegate>(delegate);
100 } 92 }
101 93
102 } // namespace content 94 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698