Display both capture and upload times in chrome://crashes.

Display both capture and upload times in chrome://crashes.

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

This patch was originally drafted by phistuck@gmail.com and
jiameng@chromium.org.

BUG=664430, 674249
Review-Url: https://codereview.chromium.org/2612993003
Cr-Commit-Position: refs/heads/master@{#442091}
Committed: https://chromium.googlesource.com/chromium/src/+/c5ffc3925eacc602f07e724560a4b0830edf108c

[Wez, 2017-01-06 02:07:34]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 02:08:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2017-01-06 02:26:47]

Description was changed from

==========
Display both capture and upload times in chrome://crashes.

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

BUG=664430,674249
==========

to

==========
Display both capture and upload times in chrome://crashes.

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

BUG=664430,674249
==========

[Wez, 2017-01-06 02:26:48]

wez@chromium.org changed reviewers:
+ rsesek@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:00:43]

Dry run: This issue passed the CQ dry run.

[Wez, 2017-01-06 03:06:10]

rsesek: PTAL :)

I've confirmed that this displays both values under Windows, and only the
upload-time under Linux.

[Wez, 2017-01-06 04:38:32]

Description was changed from

==========
Display both capture and upload times in chrome://crashes.

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

BUG=664430,674249
==========

to

==========
Display both capture and upload times in chrome://crashes.

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

This patch was originally drafted by phistuck@gmail.com and
jiameng@chromium.org.

BUG=664430,674249
==========

[PhistucK, 2017-01-06 09:50:20]

Gracias, dude.
:)

[Robert Sesek, 2017-01-06 22:30:12]

LGTM. Thanks for the fix. Makes me wonder if we should have unittests for this
page...

[Wez, 2017-01-06 23:13:30]

On 2017/01/06 22:30:12, Robert Sesek wrote:
> LGTM. Thanks for the fix. Makes me wonder if we should have unittests for this
> page...

I was thinking the same thing. Unit-testing crashes_ui_util.cc is trivial, but
to test crashes.js with it I think you'd need something like a browser test with
a fake crash provider.  WDYT?

[Wez, 2017-01-06 23:13:35]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2017-01-06 23:14:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 23:18:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483744415289000,
"parent_rev": "1de2d9771c4f9c78366f020cd6e37b5d1cc39653", "commit_rev":
"c5ffc3925eacc602f07e724560a4b0830edf108c"}

[commit-bot: I haz the power, 2017-01-06 23:18:57]

Description was changed from

==========
Display both capture and upload times in chrome://crashes.

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

This patch was originally drafted by phistuck@gmail.com and
jiameng@chromium.org.

BUG=664430,674249
==========

to

==========
Display both capture and upload times in chrome://crashes.

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

This patch was originally drafted by phistuck@gmail.com and
jiameng@chromium.org.

BUG=664430,674249

Review-Url: https://codereview.chromium.org/2612993003
Cr-Commit-Position: refs/heads/master@{#442091}
Committed:
https://chromium.googlesource.com/chromium/src/+/c5ffc3925eacc602f07e724560a4...
==========

[commit-bot: I haz the power, 2017-01-06 23:18:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c5ffc3925eacc602f07e724560a4...