fix analyzer failing to resolve loop variable nodes

fix analyzer failing resolve loop variable nodes

for example: `var item; for (item in list) { ... }`

this happens anytime ResolutionCopier is used on these, because it drops the staticElement reference for `item` in the above example.

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/95d5bf471c8d62353d110d2a184e5dc0ffd9941d

[Jennifer Messerly, 2017-01-05 03:40:01]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2017-01-05 03:40:02]

this fixes the mysterious ForEach bug you hit in your CL

[Jennifer Messerly, 2017-01-05 03:42:02]

Description was changed from

==========
fix unresolved loop variable nodes in the SDK
==========

to

==========
fix analyzer failing resolve loop variable nodes

for example: `var item; for (item in list) { ... }`

this happens anytime ResolutionCopier is used on these, because it drops the
staticElement reference for `item` in the above example.
==========

[Jennifer Messerly, 2017-01-05 03:42:18]

(updated the description)

[vsm, 2017-01-05 18:21:52]

lgtm!

[Jennifer Messerly, 2017-01-05 18:47:52]

Description was changed from

==========
fix analyzer failing resolve loop variable nodes

for example: `var item; for (item in list) { ... }`

this happens anytime ResolutionCopier is used on these, because it drops the
staticElement reference for `item` in the above example.
==========

to

==========
fix analyzer failing resolve loop variable nodes

for example: `var item; for (item in list) { ... }`

this happens anytime ResolutionCopier is used on these, because it drops the
staticElement reference for `item` in the above example.

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/95d5bf471c8d62353d110d2a184e5dc0ffd9941d
==========

[Jennifer Messerly, 2017-01-05 18:47:53]

Committed patchset #1 (id:1) manually as
95d5bf471c8d62353d110d2a184e5dc0ffd9941d (presubmit successful).