Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: pkg/dev_compiler/lib/js/amd/dart_sdk.js

Issue 2612983002: fix analyzer failing to resolve loop variable nodes (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/ast/utilities.dart ('k') | pkg/dev_compiler/lib/js/common/dart_sdk.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/js/amd/dart_sdk.js
diff --git a/pkg/dev_compiler/lib/js/amd/dart_sdk.js b/pkg/dev_compiler/lib/js/amd/dart_sdk.js
index bc1747a40bbd4477356dc94f39b683ce45a727ac..39aad5f20393450ccf1a9e0c5a3a6e30531150e9 100644
--- a/pkg/dev_compiler/lib/js/amd/dart_sdk.js
+++ b/pkg/dev_compiler/lib/js/amd/dart_sdk.js
@@ -3335,7 +3335,7 @@ define([], function() {
protoChain[dartx.add](current);
current = _debugger.safeGetProperty(current, '__proto__');
}
- for (/* Unimplemented unknown name */current of protoChain) {
+ for (current of protoChain) {
for (let symbol of _debugger.getOwnPropertySymbols(current)) {
let dartName = _debugger.symbolName(symbol);
if (dart.test(_debugger.hasMethod(object, dartName))) {
@@ -3351,7 +3351,7 @@ define([], function() {
properties.add(new _debugger.NameValuePair({name: dartName, value: value}));
}
}
- for (/* Unimplemented unknown name */current of protoChain) {
+ for (current of protoChain) {
let className = dart.dload(dart.getReifiedType(current), 'name');
for (let name of _debugger.getOwnPropertyNames(current)) {
if (dart.test(_debugger.ObjectFormatter._customNames.contains(name)) || dart.equals(name, className)) continue;
« no previous file with comments | « pkg/analyzer/lib/src/dart/ast/utilities.dart ('k') | pkg/dev_compiler/lib/js/common/dart_sdk.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698