Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: pkg/analyzer/lib/src/dart/ast/utilities.dart

Issue 2612983002: fix analyzer failing to resolve loop variable nodes (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/dev_compiler/lib/js/amd/dart_sdk.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.dart.ast.utilities; 5 library analyzer.src.dart.ast.utilities;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 import 'package:analyzer/dart/ast/ast.dart'; 9 import 'package:analyzer/dart/ast/ast.dart';
10 import 'package:analyzer/dart/ast/standard_ast_factory.dart'; 10 import 'package:analyzer/dart/ast/standard_ast_factory.dart';
(...skipping 5734 matching lines...) Expand 10 before | Expand all | Expand 10 after
5745 _isEqualNodes(node.identifier, toNode.identifier)); 5745 _isEqualNodes(node.identifier, toNode.identifier));
5746 } 5746 }
5747 5747
5748 @override 5748 @override
5749 bool visitForEachStatement(ForEachStatement node) { 5749 bool visitForEachStatement(ForEachStatement node) {
5750 ForEachStatement toNode = this._toNode as ForEachStatement; 5750 ForEachStatement toNode = this._toNode as ForEachStatement;
5751 return _and( 5751 return _and(
5752 _isEqualTokens(node.forKeyword, toNode.forKeyword), 5752 _isEqualTokens(node.forKeyword, toNode.forKeyword),
5753 _isEqualTokens(node.leftParenthesis, toNode.leftParenthesis), 5753 _isEqualTokens(node.leftParenthesis, toNode.leftParenthesis),
5754 _isEqualNodes(node.loopVariable, toNode.loopVariable), 5754 _isEqualNodes(node.loopVariable, toNode.loopVariable),
5755 _isEqualNodes(node.identifier, toNode.identifier),
5755 _isEqualTokens(node.inKeyword, toNode.inKeyword), 5756 _isEqualTokens(node.inKeyword, toNode.inKeyword),
5756 _isEqualNodes(node.iterable, toNode.iterable), 5757 _isEqualNodes(node.iterable, toNode.iterable),
5757 _isEqualTokens(node.rightParenthesis, toNode.rightParenthesis), 5758 _isEqualTokens(node.rightParenthesis, toNode.rightParenthesis),
5758 _isEqualNodes(node.body, toNode.body)); 5759 _isEqualNodes(node.body, toNode.body));
5759 } 5760 }
5760 5761
5761 @override 5762 @override
5762 bool visitFormalParameterList(FormalParameterList node) { 5763 bool visitFormalParameterList(FormalParameterList node) {
5763 FormalParameterList toNode = this._toNode as FormalParameterList; 5764 FormalParameterList toNode = this._toNode as FormalParameterList;
5764 return _and( 5765 return _and(
(...skipping 3425 matching lines...) Expand 10 before | Expand all | Expand 10 after
9190 if (node.star != null) { 9191 if (node.star != null) {
9191 sink.write("yield* "); 9192 sink.write("yield* ");
9192 } else { 9193 } else {
9193 sink.write("yield "); 9194 sink.write("yield ");
9194 } 9195 }
9195 safelyVisitNode(node.expression); 9196 safelyVisitNode(node.expression);
9196 sink.write(";"); 9197 sink.write(";");
9197 return null; 9198 return null;
9198 } 9199 }
9199 } 9200 }
OLDNEW
« no previous file with comments | « no previous file | pkg/dev_compiler/lib/js/amd/dart_sdk.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698