Remove CFX_MapPtrToPtr from xfa/fxfa.

Remove CFX_MapPtrToPtr from xfa/fxfa.

Review-Url: https://codereview.chromium.org/2612923002
Committed: https://pdfium.googlesource.com/pdfium/+/6bb3b894488fd6f38c096b708980a9f08286ac5c

[Tom Sepez, 2017-01-05 00:28:30]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 00:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-05 00:45:54]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Tom Sepez, 2017-01-05 00:45:55]

Dan, Lei, ready for review.

https://codereview.chromium.org/2612923002/diff/1/xfa/fxfa/parser/cxfa_node.cpp
File xfa/fxfa/parser/cxfa_node.cpp (left):

https://codereview.chromium.org/2612923002/diff/1/xfa/fxfa/parser/cxfa_node.c...
xfa/fxfa/parser/cxfa_node.cpp:5037: void CXFA_Node::MergeAllData(void*
pDstModule, bool bUseSrcAttr) {
note: bUseSrcData always passed as true.

https://codereview.chromium.org/2612923002/diff/1/xfa/fxfa/parser/cxfa_node.c...
xfa/fxfa/parser/cxfa_node.cpp:5058: XFA_MAPDATABLOCK*& pBuffer =
pDstModuleData->m_BufferMap[pKey];
note: renamed to pDstBuffer which results in some of the diffs below.

https://codereview.chromium.org/2612923002/diff/1/xfa/fxfa/parser/xfa_documen...
File xfa/fxfa/parser/xfa_document_datamerger_imp.cpp (left):

https://codereview.chromium.org/2612923002/diff/1/xfa/fxfa/parser/xfa_documen...
xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:779:
subformMapArray.GetStartPosition();
note: const method, noop.

[dsinclair, 2017-01-05 17:05:18]

lgtm

[Tom Sepez, 2017-01-05 17:28:47]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2017-01-05 17:28:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:15:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:15:54]

Try jobs failed on following builders:
  mac_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/...)

[Tom Sepez, 2017-01-05 18:28:03]

D'oh.

[Tom Sepez, 2017-01-05 18:28:08]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2017-01-05 18:28:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2612923002/#ps40001
(title: "endless loop")

[commit-bot: I haz the power, 2017-01-05 18:28:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 20:18:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483640888209810,
"parent_rev": "48f776f7e801d719683b251dc21ee8c0e3250d90", "commit_rev":
"6bb3b894488fd6f38c096b708980a9f08286ac5c"}

[commit-bot: I haz the power, 2017-01-05 20:18:44]

Description was changed from

==========
Remove CFX_MapPtrToPtr from xfa/fxfa.
==========

to

==========
Remove CFX_MapPtrToPtr from xfa/fxfa.

Review-Url: https://codereview.chromium.org/2612923002
Committed:
https://pdfium.googlesource.com/pdfium/+/6bb3b894488fd6f38c096b708980a9f08286...
==========

[commit-bot: I haz the power, 2017-01-05 20:18:44]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/6bb3b894488fd6f38c096b708980a9f08286...