Remove CFX_MapPtrToPtr from xfa/fxfa.

xfa/fxfa/app/xfa_textlayout.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/app/xfa_textlayout.h"
 
 #include <algorithm>
 
@@ skipping 48 matching lines @@
   FXSYS_memcpy(m_ppMatchedDecls, ppDeclArray,
                iDeclCount * sizeof(CFDE_CSSDeclaration*));
 }
 
 CXFA_TextParser::CXFA_TextParser() : m_pUASheet(nullptr) {}
 
 CXFA_TextParser::~CXFA_TextParser() {
   if (m_pUASheet)
     m_pUASheet->Release();
 
-  FX_POSITION ps = m_mapXMLNodeToParseContext.GetStartPosition();
-  while (ps) {
-    CFDE_XMLNode* pXMLNode;
-    CXFA_TextParseContext* pParseContext;
-    m_mapXMLNodeToParseContext.GetNextAssoc(ps, pXMLNode, pParseContext);
-    if (pParseContext)
+  for (auto& pair : m_mapXMLNodeToParseContext) {
+    if (pair.second) {
       FXTARGET_DeleteWith(CXFA_TextParseContext, m_pAllocator.get(),
-                          pParseContext);
+                          pair.second);
+    }
   }
-  m_mapXMLNodeToParseContext.RemoveAll();
 }
+
 void CXFA_TextParser::Reset() {
-  FX_POSITION ps = m_mapXMLNodeToParseContext.GetStartPosition();
-  while (ps) {
-    CFDE_XMLNode* pXMLNode;
-    CXFA_TextParseContext* pParseContext;
-    m_mapXMLNodeToParseContext.GetNextAssoc(ps, pXMLNode, pParseContext);
-    if (pParseContext)
+  for (auto& pair : m_mapXMLNodeToParseContext) {
+    if (pair.second) {
       FXTARGET_DeleteWith(CXFA_TextParseContext, m_pAllocator.get(),
-                          pParseContext);
+                          pair.second);
+    }
   }
-  m_mapXMLNodeToParseContext.RemoveAll();
+  m_mapXMLNodeToParseContext.clear();
   m_pAllocator.reset();
 }
 void CXFA_TextParser::InitCSSData(CXFA_TextProvider* pTextProvider) {
   if (!pTextProvider)
     return;
 
   if (!m_pSelector) {
     CXFA_FFDoc* pDoc = pTextProvider->GetDocNode();
     CFGAS_FontMgr* pFontMgr = pDoc->GetApp()->GetFDEFontMgr();
     ASSERT(pFontMgr);
@@ skipping 119 matching lines @@
     pParaStyle->SetNumberVerticalAlign(fBaseLine);
     IFDE_CSSBoundaryStyle* pBoundarytyle = pParentStyle->GetBoundaryStyles();
     const FDE_CSSRECT* pRect = pBoundarytyle->GetMarginWidth();
     if (pRect) {
       pBoundarytyle = pNewStyle->GetBoundaryStyles();
       pBoundarytyle->SetMarginWidth(*pRect);
     }
   }
   return pNewStyle;
 }
+
 IFDE_CSSComputedStyle* CXFA_TextParser::ComputeStyle(
     CFDE_XMLNode* pXMLNode,
     IFDE_CSSComputedStyle* pParentStyle) {
-  CXFA_TextParseContext* pContext = static_cast<CXFA_TextParseContext*>(
-      m_mapXMLNodeToParseContext.GetValueAt(pXMLNode));
+  auto it = m_mapXMLNodeToParseContext.find(pXMLNode);
+  if (it == m_mapXMLNodeToParseContext.end())
+    return nullptr;
+
+  CXFA_TextParseContext* pContext = it->second;
   if (!pContext)
     return nullptr;
+
   pContext->m_pParentStyle = pParentStyle;
   pParentStyle->Retain();
+
   CXFA_CSSTagProvider tagProvider;
   ParseTagInfo(pXMLNode, tagProvider);
   if (tagProvider.m_bContent)
     return nullptr;
+
   IFDE_CSSComputedStyle* pStyle = CreateStyle(pParentStyle);
   CFDE_CSSAccelerator* pCSSAccel = m_pSelector->InitAccelerator();
   pCSSAccel->OnEnterTag(&tagProvider);
   m_pSelector->ComputeStyle(&tagProvider, pContext->GetDecls(),
                             pContext->CountDecls(), pStyle);
   pCSSAccel->OnLeaveTag(&tagProvider);
   return pStyle;
 }
 void CXFA_TextParser::DoParse(CFDE_XMLNode* pXMLContainer,
                               CXFA_TextProvider* pTextProvider) {
@@ skipping 34 matching lines @@
           const_cast<const CFDE_CSSDeclaration**>(DeclArray.GetData());
       m_pSelector->ComputeStyle(&tagProvider, ppMatchDecls, iMatchedDecls,
                                 pNewStyle);
       pCSSAccel->OnLeaveTag(&tagProvider);
       if (iMatchedDecls > 0) {
         pTextContext->SetDecls(ppMatchDecls, iMatchedDecls);
       }
       eDisplay = pNewStyle->GetPositionStyles()->GetDisplay();
     }
     pTextContext->SetDisplay(eDisplay);
-    m_mapXMLNodeToParseContext.SetAt(pXMLNode, pTextContext);
+    m_mapXMLNodeToParseContext[pXMLNode] = pTextContext;
   }
   for (CFDE_XMLNode* pXMLChild =
            pXMLNode->GetNodeItem(CFDE_XMLNode::FirstChild);
        pXMLChild;
        pXMLChild = pXMLChild->GetNodeItem(CFDE_XMLNode::NextSibling)) {
     ParseRichText(pXMLChild, pNewStyle);
   }
   if (pNewStyle)
     pNewStyle->Release();
 }
@@ skipping 108 matching lines @@
   if (font) {
     return font.GetFontSize();
   }
   return 10;
 }
 int32_t CXFA_TextParser::GetHorScale(CXFA_TextProvider* pTextProvider,
                                      IFDE_CSSComputedStyle* pStyle,
                                      CFDE_XMLNode* pXMLNode) const {
   if (pStyle) {
     CFX_WideString wsValue;
-    if (pStyle->GetCustomStyle(FX_WSTRC(L"xfa-font-horizontal-scale"),
-                               wsValue)) {
+    if (pStyle->GetCustomStyle(L"xfa-font-horizontal-scale", wsValue)) {
       return wsValue.GetInteger();
     }
     while (pXMLNode) {
-      CXFA_TextParseContext* pContext = static_cast<CXFA_TextParseContext*>(
-          m_mapXMLNodeToParseContext.GetValueAt(pXMLNode));
-      if (pContext && pContext->m_pParentStyle &&
-          pContext->m_pParentStyle->GetCustomStyle(
-              FX_WSTRC(L"xfa-font-horizontal-scale"), wsValue)) {
-        return wsValue.GetInteger();
+      auto it = m_mapXMLNodeToParseContext.find(pXMLNode);
+      if (it != m_mapXMLNodeToParseContext.end()) {
+        CXFA_TextParseContext* pContext = it->second;
+        if (pContext && pContext->m_pParentStyle &&
+            pContext->m_pParentStyle->GetCustomStyle(
+                L"xfa-font-horizontal-scale", wsValue)) {
+          return wsValue.GetInteger();
+        }
       }
       pXMLNode = pXMLNode->GetNodeItem(CFDE_XMLNode::Parent);
     }
   }
   if (CXFA_Font font = pTextProvider->GetFontNode()) {
     return static_cast<int32_t>(font.GetHorizontalScale());
   }
   return 100;
 }
 int32_t CXFA_TextParser::GetVerScale(CXFA_TextProvider* pTextProvider,
@@ skipping 133 matching lines @@
       ws.MakeLower();
     }
     bool bRaw = (ws == FX_WSTRC(L"raw"));
     if (!bRaw && ws != FX_WSTRC(L"formatted")) {
       return false;
     }
     bRet = pTextProvider->GetEmbbedObj(bURI, bRaw, wsAttr, wsValue);
   }
   return bRet;
 }
+
 CXFA_TextParseContext* CXFA_TextParser::GetParseContextFromMap(
     CFDE_XMLNode* pXMLNode) {
-  return (CXFA_TextParseContext*)m_mapXMLNodeToParseContext.GetValueAt(
-      pXMLNode);
+  auto it = m_mapXMLNodeToParseContext.find(pXMLNode);
+  return it != m_mapXMLNodeToParseContext.end() ? it->second : nullptr;
 }
+
 enum XFA_TABSTOPSSTATUS {
   XFA_TABSTOPSSTATUS_Error,
   XFA_TABSTOPSSTATUS_EOS,
   XFA_TABSTOPSSTATUS_None,
   XFA_TABSTOPSSTATUS_Alignment,
   XFA_TABSTOPSSTATUS_StartLeader,
   XFA_TABSTOPSSTATUS_Leader,
   XFA_TABSTOPSSTATUS_Location,
 };
 bool CXFA_TextParser::GetTabstops(IFDE_CSSComputedStyle* pStyle,
@@ skipping 1491 matching lines @@
   m_tabstops.RemoveAll();
   m_iTabCount = 0;
 }
 
 void CXFA_TextTabstopsContext::Reset() {
   m_iTabIndex = -1;
   m_bTabstops = false;
   m_fTabWidth = 0;
   m_fLeft = 0;
 }